From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B420EA0350; Tue, 23 Jun 2020 23:20:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D384C1D6D7; Tue, 23 Jun 2020 23:20:42 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 71D831D6D5 for ; Tue, 23 Jun 2020 23:20:41 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id bh7so9664359plb.11 for ; Tue, 23 Jun 2020 14:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fnoER8Yls4M3gDl6jP7qiFvyTl3evkzrOaj7eeqHF3k=; b=i3Oz0117rySyg2TbH5v2XgQzN0QQcx2ckgmlJgtJtnH3nosFV9qBFLMgWScGoMXFtA iMKZi/ihbj/VByzXMO5yV7cCf5B0fr5TK7vn1/3twrt5/Ub57OdCG2Ed87bcemdpBmFj AGQ9EGC+c54B1hwG1DqJ3ApvnSTkm+8epWveIGoEeFwznj0Qwy2iuUuNVqsSG4C0v0l6 wL7i3HrSmw3eFpC8tL2q9zThirP0/O0DmeQA0SfCecy/ss+m2TkZ9JBLdUY2yn4Azr/I zy8joHPN3tbi7yUDcIMvvp0wC9M7U57l6P4hzBqEIaInphk2UCP6OQdQFaWW+5tarXQK G9kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fnoER8Yls4M3gDl6jP7qiFvyTl3evkzrOaj7eeqHF3k=; b=FK6QF8sag7q3j9h7Rs/Vis/73Nmfb1dL3xVwz/AByryfhX3hM+AiVF9XC1uSF/0J1T 2RtgmLpWpQ8ceFRP6D8guxeTMFvI5oN9JyUY34ZRm5a8OTVjlU4eJFeIJGWVJM0IFFph pR/o6BTFNNn/hILGNyl5jEZC3UKEcbJxEl0yggovA6iDysQpoUyI9XvWgkW60lH9/RsJ rwyymAVclLYqOL2qu4N++KRvJ8pxnFiK98SBa3+AVqymIMttFE5xnKD9k71pk5yCJwmA k9hdGCTKEQsnjm9oyfa4XuCTANO+37dpI43ZI5VUNJWjZMAVlayqs0H31FRWS16puu/c 7NxQ== X-Gm-Message-State: AOAM530BR+rKRxX9DdfMxQ0YSA6HPchzRvrso4YgbQliHsc/1HoHKiyJ QY0+dntQOtNId/zF8fkYVlHpZw== X-Google-Smtp-Source: ABdhPJzd+DD6wdmZOe7Px7VeoPf1CQNJbOHBGQUjw8ht3jwJcwwqgiaimGKP2ZCLq9ZNeOf7ZCM6hA== X-Received: by 2002:a17:902:a606:: with SMTP id u6mr19589455plq.94.1592947240436; Tue, 23 Jun 2020 14:20:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r9sm18679604pfq.31.2020.06.23.14.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 14:20:40 -0700 (PDT) Date: Tue, 23 Jun 2020 14:20:02 -0700 From: Stephen Hemminger To: Phil Yang Cc: dev@dpdk.org, erik.g.carrillo@intel.com, drc@linux.vnet.ibm.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, dharmik.thakkar@arm.com, nd@arm.com Message-ID: <20200623142002.6b997568@hermes.lan> In-Reply-To: <1591960798-24024-2-git-send-email-phil.yang@arm.com> References: <1591960798-24024-1-git-send-email-phil.yang@arm.com> <1591960798-24024-2-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 12 Jun 2020 19:19:57 +0800 Phil Yang wrote: > /* Track which cores have actually armed a timer */ > struct { > - rte_atomic16_t v; > + int16_t v; > } __rte_cache_aligned in_use[RTE_MAX_LCORE]; Do you really need this to be cache aligned (ie one per line)? Why have a signed value for a reference count? Shouldn't it be unsigned?