From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DA66A0350; Wed, 24 Jun 2020 10:08:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF3761D98A; Wed, 24 Jun 2020 10:02:32 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9BEC11D99B for ; Wed, 24 Jun 2020 10:02:29 +0200 (CEST) IronPort-SDR: R8HxH6+MM08pWaGliJPyoM4S9uKZ6vR8R3KwusF5M852g8hmlYYV/g3eUx1OAVKtAEKsHAAsuG zO8YTs9WPPcQ== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="143472974" X-IronPort-AV: E=Sophos;i="5.75,274,1589266800"; d="scan'208";a="143472974" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 01:02:29 -0700 IronPort-SDR: ++xcHPl8r5F25LU7jw45ZIEZzcv02zCfGd7djCe31JXcpkvSaE24Ph1hDoQME6i6IiFB1ZiPk9 R4hqf51j6M7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,274,1589266800"; d="scan'208";a="385102974" Received: from intel.sh.intel.com ([10.239.255.48]) by fmsmga001.fm.intel.com with ESMTP; 24 Jun 2020 01:02:27 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Jeff Guo , Wenzhuo Lu , Guinan Sun , Jeb Cramer Date: Wed, 24 Jun 2020 07:53:25 +0000 Message-Id: <20200624075337.6768-31-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200624075337.6768-1-guinanx.sun@intel.com> References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200624075337.6768-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 30/42] net/e1000/base: remove useless statement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As it stands now, this fix will not change the current functionality of the code. In addition, we remove the comment that seemed to be a copy/paste from a separate implementation. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c index b79e3bad8..9b9cc7d90 100644 --- a/drivers/net/e1000/base/e1000_ich8lan.c +++ b/drivers/net/e1000/base/e1000_ich8lan.c @@ -4113,13 +4113,6 @@ STATIC s32 e1000_update_nvm_checksum_spt(struct e1000_hw *hw) if (ret_val) goto release; - /* And invalidate the previously valid segment by setting - * its signature word (0x13) high_byte to 0b. This can be - * done without an erase because flash erase sets all bits - * to 1's. We can write 1's to 0's without an erase - */ - act_offset = (old_bank_offset + E1000_ICH_NVM_SIG_WORD) * 2 + 1; - /* offset in words but we read dword*/ act_offset = old_bank_offset + E1000_ICH_NVM_SIG_WORD - 1; ret_val = e1000_read_flash_dword_ich8lan(hw, act_offset, &dword); -- 2.17.1