From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29ABEA0350; Thu, 25 Jun 2020 16:01:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B42F1B6B4; Thu, 25 Jun 2020 16:01:13 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CBD472B8B; Thu, 25 Jun 2020 16:01:10 +0200 (CEST) IronPort-SDR: MyyerW+ljTvkyQwZmTtDoTLvY4B7fzAwQV6JtPBzXw/hArk+eS81iIIR0X0ywTDglyRd7g0i+L 8iQwP7UN+dEA== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="229604158" X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="229604158" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 07:01:08 -0700 IronPort-SDR: CLngmhp55SJGDSv69QumcieQTluID/iao4Tq74f6reADniLIvZAwnHuzl//j+Q3r9/5bsSVi81 8mgH1+Z/viBA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="276026146" Received: from silpixa00399839.ir.intel.com (HELO localhost.localdomain) ([10.237.222.8]) by orsmga003.jf.intel.com with ESMTP; 25 Jun 2020 07:01:07 -0700 From: Ciara Loftus To: dev@dpdk.org Cc: xiao.w.wang@intel.com, Ciara Loftus , stable@dpdk.org Date: Thu, 25 Jun 2020 13:39:50 +0000 Message-Id: <20200625133950.8028-1-ciara.loftus@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/af_xdp: revert change to SP/SC ring for copy mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This reverts commit 489e0b5b33209d929dc490cc591abd840dcefdfc. The ring used in copy mode should be multi-producer multi-consumer because enqueues and dequeues to the ring are performed on both the rx and tx paths, which can be running on different threads. Fixes: 489e0b5b3320 ("net/af_xdp: use single producer/consumer ring") Cc: stable@dpdk.org Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 06124ba789..2fab916d75 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -820,7 +820,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, umem->buf_ring = rte_ring_create(ring_name, ETH_AF_XDP_NUM_BUFFERS, rte_socket_id(), - RING_F_SP_ENQ | RING_F_SC_DEQ); + 0x0); if (umem->buf_ring == NULL) { AF_XDP_LOG(ERR, "Failed to create rte_ring\n"); goto err; -- 2.17.1