From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 301CAA0350; Thu, 25 Jun 2020 17:32:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B190D4F9C; Thu, 25 Jun 2020 17:32:00 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id BBB1D29CB for ; Thu, 25 Jun 2020 17:31:59 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id h15so6288566wrq.8 for ; Thu, 25 Jun 2020 08:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Defd6Pb0E0a376+K1TvhctzpgboT60d+eo3CFsHpTik=; b=Vcm0bOV/YI+X+VxxIw+GYcBbSv2stdfFKegG3KC3RB7wUlQM4YZADmPAs0Lr69I5xn k0SCGPaJA2rB4VVXPO95Nn/VdtJCqIN6a5o6lZVlzOrdW0VI0EC93fU1YkOdgpZaTZr8 mgGIUUm6iP03RKNr5O9vaeNDZs2zS+CHEgp6LCXsUjLjXw57hdM8Yzg9A7ScjRclTJ1P RC6rwI0e4H8flEGpbDTfCmGlj7EfJH6+NCMOoyVZQdEDLiWRIyuZdSwQ829c5zhSF/8Q 9eQmv13qL42TfAlPy03nU2XuF+x+blvRo5T2LvA7dp9gNOIlUw+PfN/tBpyZ8Kkgn4TV HmTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Defd6Pb0E0a376+K1TvhctzpgboT60d+eo3CFsHpTik=; b=USZ1iql8xcAXXSK5tVhwGkx6bWhHAXV+w4CJUkcfYrlA3GxR4FKYWKzzZg8QAi7bHB FcqxqUBPBzasA/pIVvGvt8nUl9Op/DvFWzAKRiPo4S4ImnfZ4G1nFL9P4V6fhvt6Qh50 iT4Ph5HReZ/9L+XXFMKPNdDhA68qPMhx5hyJDbzEz3LsjZvgvToXLrbmzt3BpMU/7bKC 25O3tTODH0BS9SJwI1IjrWInFCEHD7soCgZtwiM8yBAEO04e7JWFLZumCGOlA6dNiyfj MopAwJ2y3b2yoTQ3uW6uFHfHyKmcq10WMIY3UTqPrJDFjVluELLKIL0YoGEup88A98BE SLbg== X-Gm-Message-State: AOAM530zXcrr3iEsd3Vl8pe2i0OzJ/oCx8bc62/a0lrkqS63JV9C9TLr 5rHDARoyDD0S5UlrozSg3SRNlw== X-Google-Smtp-Source: ABdhPJxboHDTuqAqQ9KonbeqcUaggUWkybwaxPV3PsSBEYZFAvUq9Fjq5qayPdFSwc0Mb+UGXmOTyg== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr37853102wru.324.1593099119456; Thu, 25 Jun 2020 08:31:59 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id u65sm13517802wmg.5.2020.06.25.08.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 08:31:58 -0700 (PDT) Date: Thu, 25 Jun 2020 17:31:58 +0200 From: Olivier Matz To: Xiaolong Ye Cc: Konstantin Ananyev , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org Message-ID: <20200625153158.GP12564@platinum> References: <20200613154922.42379-1-xiaolong.ye@intel.com> <20200613154922.42379-3-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200613154922.42379-3-xiaolong.ye@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/5] mbuf: fix missing errno for dyn field/flag registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Jun 13, 2020 at 11:49:18PM +0800, Xiaolong Ye wrote: > Set rte_errno as ENOMEM when allocation failure. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Cc: stable@dpdk.org > > Signed-off-by: Xiaolong Ye Good catch, I was wrongly expecting that rte_malloc() functions sets rte_errno on error. I wonder if the malloc API shouldn't be modified, because I can see several places where the same kind of fix would be needed: rte_efd, rte_cuckoo_hash, rte_fbk_hash, rte_member, ... Anatoly, what do you think? Acked-by: Olivier Matz