From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 711CAA0350; Thu, 25 Jun 2020 23:44:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9B321BDAE; Thu, 25 Jun 2020 23:44:07 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 95CBC1B3BB for ; Thu, 25 Jun 2020 23:44:03 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id AB1C87F4; Thu, 25 Jun 2020 17:44:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 25 Jun 2020 17:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=aWieujkoesWJ8 tCBMayup6393b3IVSUTAGeLsn6QSGk=; b=seHdNzwwlTI25bJzFTDdakvE58hfw 1FCj+LXlw2jgTssaJR7/josnWmujjNUXk8eDy9wBanXY32w1XeQVKay6njtEpTyS lCzSVHr8JloC3AQS3jNqoPb8/Tx4N6gZUQNR7y8M26PqvxsaxCVml0ngnMSZqyRH GCjDqO7diKkxAhNEcMYgwkfVKMW5jrYvPjGlWNgV55jS0V9i7WtEfnjGV7DPWTy2 7nL6wZLGR9Fsr47RHkVU3sSEL2uA6UH6S6WcKwN9LScLXhfcSUSHMc+f1G0HFZpa zN+e/coL0gXftKHnu/Ck/JFNoe73j1tV+hTrbrCytPcSkqVFuePa0ZsvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=aWieujkoesWJ8tCBMayup6393b3IVSUTAGeLsn6QSGk=; b=VtJm6uUO 07Qg0YPWJ7+SYaYOZlPbriIr9XpMLyBVn/zaZitaWZyoV2uaf0yp5ZAsigS3VBAO ytVt+24D+X+H35iMzyeKrPJd+Tt7nIQrs7mo+NPRXK9WIFkRnciZfUvU02zH5W96 VQtl7Ll7mvG5UQRft8Sf/XW+LSqCKuqkzMMbovoJgFXMli1Bq5lbGeAizq8Xlp9E YgsOsum3rtlp6LK7yWT4lQIB/bTHlAwkJ56s2jrTFAJbDXHv+gNFf7Ualu8hyvPe UZVAY/tGcIhTKSegXDgb/BFvcTbcr+hgmvRgZXF4r4s5wSNmy7IQ/eGSf9XoaZat jADGaKp3e4aojQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeltddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeelleeuvddtheefteeuhe euffevudegjedtkeefueekjeeuhfelkefhheeikefhleenucffohhmrghinhepughpughk rdhorhhgpdhsughktghonhhfihhgrdhmkhdpshgukhhrohhothdrmhhkpdhsughksghuih hlugdrmhhknecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A006C328005E; Thu, 25 Jun 2020 17:44:01 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com Date: Thu, 25 Jun 2020 23:43:38 +0200 Message-Id: <20200625214338.1838457-5-thomas@monjalon.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625214338.1838457-1-thomas@monjalon.net> References: <20200618004218.3730743-1-thomas@monjalon.net> <20200625214338.1838457-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 4/4] mk: add a paused deprecation warning before each build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" DPDK 20.05 had some deprecation notes after "make config" and after the build. For DPDK 20.08, the config note is replaced with a warning before the config and before the build. After the warning, there is a pause which can be skipped with the variable MAKE_PAUSE. This deprecation process was discussed in the Technical Board: http://mails.dpdk.org/archives/dev/2020-April/162839.html Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson --- mk/rte.sdkconfig.mk | 5 ----- mk/rte.sdkroot.mk | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk index 2ea85e4643..f538649f22 100644 --- a/mk/rte.sdkconfig.mk +++ b/mk/rte.sdkconfig.mk @@ -62,11 +62,6 @@ else config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile @echo "Configuration done using" \ $(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE))) - @echo "==== NOTE ====" - @echo "It is recommended to build DPDK using 'meson' and 'ninja'" - @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions" - @echo "Building DPDK with 'make' will be deprecated in a future release" - @echo "==============" endif $(RTE_OUTPUT): diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk index 4043a9d4e8..d3b9cdd048 100644 --- a/mk/rte.sdkroot.mk +++ b/mk/rte.sdkroot.mk @@ -60,7 +60,22 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n .PHONY: default test-build default test-build: all +.PHONY: warning +warning: + @echo + @echo "=========================== WARNING ============================" + @echo "It is recommended to build DPDK using 'meson' and 'ninja'" + @echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html" + @echo "Building DPDK with 'make' will be deprecated in a future release" + @echo "================================================================" + @echo + @test "$(MAKE_PAUSE)" = n || ( \ + echo "This deprecation warning can be passed by adding MAKE_PAUSE=n"; \ + echo "to 'make' command line or as an exported environment variable."; \ + echo "Press enter to continue..."; read) + .PHONY: config defconfig showconfigs showversion showversionum +config: warning config defconfig showconfigs showversion showversionum: $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ @@ -96,4 +111,5 @@ examples examples_clean: # all other build targets %: $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkroot.mk warning $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ -- 2.26.2