From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3201FA051C; Fri, 26 Jun 2020 16:48:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08CAF1C0D1; Fri, 26 Jun 2020 16:48:13 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 3746D1C0BF for <dev@dpdk.org>; Fri, 26 Jun 2020 16:48:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593182891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zX7MaCbY98XPXNXERMCKGh1uw+eDHjwbOYs0Afu5RtU=; b=Afsvk6CnBwtWUBuhZxyKQkL/gIAGCvkTwzIPyoycbaLIuzLJWVV5dNzryUIsQKzMz4T4gE MKIPzXGvbeAaFtXdRl1at4/VMDTVralHgMHgEMmh5/KQXeREZ3WO/tymhoef7f/gRwNg03 k1R1jaTI0LqafAFmtivgAqdeZO8OMfU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-nqrOuLPuPdO0-DIOHZZh4g-1; Fri, 26 Jun 2020 10:48:03 -0400 X-MC-Unique: nqrOuLPuPdO0-DIOHZZh4g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 283158064B4; Fri, 26 Jun 2020 14:48:01 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CB277FEBE; Fri, 26 Jun 2020 14:47:58 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: jerinjacobk@gmail.com, bruce.richardson@intel.com, mdr@ashroe.eu, thomas@monjalon.net, arybchenko@solarflare.com, ktraynor@redhat.com, ian.stokes@intel.com, i.maximets@ovn.org Date: Fri, 26 Jun 2020 16:47:27 +0200 Message-Id: <20200626144736.11011-1-david.marchand@redhat.com> In-Reply-To: <20200610144506.30505-1-david.marchand@redhat.com> References: <20200610144506.30505-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 0/9] Register non-EAL threads as lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> OVS and some other applications have been hacking into DPDK internals to fake EAL threads and avoid performance penalty of only having non-EAL threads. This series proposes to add a new type of lcores and maps those threads to such lcores. non-EAL threads won't run the DPDK eal mainloop. As a consequence, part of the EAL threads API cannot work. Having new lcores appearing during the process lifetime is not expected by some DPDK components. This is addressed by introducing init/uninit callacks invoked when hotplugging of such lcore. There is still some work/discussion: - refuse new lcore role in incompatible EAL threads API (or document it only as those API were already incompatible?), - think about deprecation notices for existing RTE_FOREACH_LCORE macros and consorts, it is probably worth discussing on how to iterate over lcores, For the interested parties, I have a patch [1] against dpdk-latest OVS branch that makes use of this series. 1: https://patchwork.ozlabs.org/project/openvswitch/patch/20200626123017.28555-1-david.marchand@redhat.com/ Changes since v3: - added init failure when trying to use in conjunction with multiprocess, - addressed Andrew comments, Changes since v2: - fixed windows build error due to missing trace stub, - fixed bug when rolling back on lcore register, Changes since v1: - rebased on master (conflicts on merged Windows series), - separated lcore role code cleanup in a patch, - tried to use a single naming, so kept non-EAL threads as the main notion. non-EAL threads are then distinguished between registered and unregistered non-EAL threads, - added unit tests (still missing some coverage, marked with a FIXME), - reworked callbacks call under a common rwlock lock which protects lcores allocations and callbacks registration, - introduced lcore iterators and converted the bucket mempool driver, -- David Marchand David Marchand (9): eal: relocate per thread symbols to common eal: fix multiple definition of per lcore thread id eal: introduce thread init helper eal: introduce thread uninit helper eal: move lcore role code eal: register non-EAL threads as lcores eal: add lcore init callbacks eal: add lcore iterators mempool/bucket: handle non-EAL lcores MAINTAINERS | 1 + app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_lcores.c | 372 ++++++++++++++++++ doc/guides/howto/debug_troubleshoot.rst | 5 +- .../prog_guide/env_abstraction_layer.rst | 22 +- doc/guides/prog_guide/mempool_lib.rst | 2 +- drivers/mempool/bucket/rte_mempool_bucket.c | 130 +++--- lib/librte_eal/common/eal_common_lcore.c | 246 +++++++++++- lib/librte_eal/common/eal_common_mcfg.c | 36 ++ lib/librte_eal/common/eal_common_thread.c | 126 ++++-- lib/librte_eal/common/eal_common_trace.c | 51 ++- lib/librte_eal/common/eal_memcfg.h | 10 + lib/librte_eal/common/eal_private.h | 19 + lib/librte_eal/common/eal_thread.h | 26 +- lib/librte_eal/common/eal_trace.h | 2 +- lib/librte_eal/freebsd/eal.c | 20 +- lib/librte_eal/freebsd/eal_thread.c | 38 +- lib/librte_eal/include/rte_eal.h | 12 +- lib/librte_eal/include/rte_lcore.h | 174 +++++++- lib/librte_eal/include/rte_trace_point.h | 9 + lib/librte_eal/linux/eal.c | 21 +- lib/librte_eal/linux/eal_thread.c | 38 +- lib/librte_eal/rte_eal_version.map | 16 + lib/librte_eal/windows/eal.c | 8 +- lib/librte_eal/windows/eal_thread.c | 14 +- lib/librte_mempool/rte_mempool.h | 11 +- 28 files changed, 1179 insertions(+), 239 deletions(-) create mode 100644 app/test/test_lcores.c -- 2.23.0