From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D769EA0520; Sat, 27 Jun 2020 03:54:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CA591B5E1; Sat, 27 Jun 2020 03:54:41 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by dpdk.org (Postfix) with ESMTP id 8F6A1255 for ; Sat, 27 Jun 2020 03:54:40 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id CD2A120B4901; Fri, 26 Jun 2020 18:54:39 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD2A120B4901 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1593222879; bh=V1jNWLJHy2nh6l8rh4Qt2GdnXDAkFAI42bqF0pml88c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QEEaDKplWKwmqiO7HGdhsSoW8/g//neg8uyQDy+vc0Jt1SHVj8vP3YnPHZMnxf/Q2 FiHyybKqCbDWq+4G0wg32D/XMpxYqZ7GWqewK0HUNIgWpspWDhTQguUGorbUYEmtlx Ts1l0JvOYYAHTlBMoTORKUmuoXmtWCwn9LiQ+Wu4= Date: Fri, 26 Jun 2020 18:54:39 -0700 From: Narcisa Ana Maria Vasile To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, fady@mellanox.com, bruce.richardson@intel.com Message-ID: <20200627015439.GB10439@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20200622075529.24180-2-talshn@mellanox.com> <20200624082847.21344-1-talshn@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624082847.21344-1-talshn@mellanox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v9 00/10] Windows bus/pci support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 24, 2020 at 11:28:37AM +0300, talshn@mellanox.com wrote: > From: Tal Shnaiderman > > This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. > > --- > v9: > * Split the patch of common OS file to config and options patches (ThomasM). > * Remove rte_ prefixes from new functions as they are eal internal (ThomasM). > ^ Move common declarations to eal_private.h. > * Add get_pci_hardware_id and parse_pci_hardware_id in pci.c (DmitryK) > * Fix issues in pci.c (DmitryK) > v8: > * Move internal_config to static inside eal_common_config.c and use getters for all external uses. > * Fix duplicated export line (FadyB) > * Fix FreeBSD missing function. > v7: > * Remove Unneeded code from MinGW mapping script (DmitryK) > * Fix error flow issues in pci.c (DmitryK) > * Fix Unix build errors following unity of common functions. > * Move strerror to rte_strerror (DmitryK) > v6: > * Fix duplication of exported functions for mingw by modifying the version.map in build (new commit) > * Fix comments and move additional functions to eal_common_config (DavidM) > * Fix cross-compilation in mingw (DmitryK) > * Fix Warnings > * Move off_t type to pci (ThomasM) > v5: > * Adjust mem-mapping functions to changes in latest memory management patchset. > * Fix incorrect implib definition in drivers/meson.build > v4: > * Fixed various warnings and naming conventions(DmitryK). > * Fixed broken mingw-64 build(DmitryK). > * Improved logging(DmitryK). > * Added patch to fix warnings on rte_pci_addr logging. > * Fixed broken make on linux/freebsd. > v3: > * Changes in BDF and hardware ids retrieval(DmitryK). > * Apply new generic MM to all pci unix callers(DmitryK). > * Minor corrections in pci.c(DmitryK). > v2: > * fix style issues. > * fix error handing flow in pci.c > * change eal_config.c to eal_common_config.c > --- Compiled successfully with clang 9.0.0. 2 warnings are generated, suggesting using safer versions of getenv() and strncpy(). Do we have any test application to test with? dpdk-helloworld runs successfully.