DPDK patches and discussions
 help / color / mirror / Atom feed
From: Qi Zhang <qi.z.zhang@intel.com>
To: qiming.yang@intel.com
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
	stable@dpdk.org, Vignesh Sridhar <vignesh.sridhar@intel.com>,
	Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Subject: [dpdk-dev] [PATCH 7/8] net/ice/base: clear and free XLT entries on reset
Date: Sat, 27 Jun 2020 23:06:14 +0800	[thread overview]
Message-ID: <20200627150615.2233-8-qi.z.zhang@intel.com> (raw)
In-Reply-To: <20200627150615.2233-1-qi.z.zhang@intel.com>

This fix has been added to address memory leak issues resulting from
triggering a sudden driver reset which does not allow us to follow our
normal removal flows for SW XLT entries for advanced features.

- Adding call to destroy flow profile locks when clearing SW XLT tables.
- Extraction sequence entries were not correctly cleared previously
which could cause ownership conflicts for repeated reset-replay calls.

Fixes: 969890d505b1 ("net/ice/base: enable clearing of HW tables")
Cc: stable@dpdk.org

Signed-off-by: Vignesh Sridhar <vignesh.sridhar@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
 drivers/net/ice/base/ice_flex_pipe.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 016dc2b39..284569464 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3666,6 +3666,8 @@ static void ice_free_flow_profs(struct ice_hw *hw, u8 blk_idx)
 		if (p->acts)
 			ice_free(hw, p->acts);
+		ice_destroy_lock(&p->entries_lock);
 		ice_free(hw, p);
@@ -3794,7 +3796,7 @@ void ice_clear_hw_tbls(struct ice_hw *hw)
 			   prof_redir->count * sizeof(*prof_redir->t),
-		ice_memset(es->t, 0, es->count * sizeof(*es->t),
+		ice_memset(es->t, 0, es->count * sizeof(*es->t) * es->fvw,
 		ice_memset(es->ref_count, 0, es->count * sizeof(*es->ref_count),

  parent reply	other threads:[~2020-06-27 15:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 15:06 [dpdk-dev] [PATCH 0/8] update base code batch 3 Qi Zhang
2020-06-27 15:06 ` [dpdk-dev] [PATCH 1/8] net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist Qi Zhang
2020-06-27 15:06 ` [dpdk-dev] [PATCH 2/8] net/ice/base: cleanup some code style Qi Zhang
2020-06-27 15:06 ` [dpdk-dev] [PATCH 3/8] net/ice/base: move lldp function to common module Qi Zhang
2020-06-27 15:06 ` [dpdk-dev] [PATCH 4/8] net/ice/base: code clean in FDIR module Qi Zhang
2020-06-29  2:46   ` Yang, Qiming
2020-06-27 15:06 ` [dpdk-dev] [PATCH 5/8] net/ice/base: add capability list AQ function Qi Zhang
2020-06-27 15:06 ` [dpdk-dev] [PATCH 6/8] net/ice/base: split capability parse into separate functions Qi Zhang
2020-06-27 15:06 ` Qi Zhang [this message]
2020-06-27 15:06 ` [dpdk-dev] [PATCH 8/8] net/ice/base: update version Qi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627150615.2233-8-qi.z.zhang@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=paul.m.stillwell.jr@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=vignesh.sridhar@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).