From: "Gaëtan Rivet" <grive@u256.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, wenzhuo.lu@intel.com,
beilei.xing@intel.com, bernard.iremonger@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 (v20.11) 2/2] eal: improve device probing API
Date: Mon, 29 Jun 2020 11:57:11 +0200 [thread overview]
Message-ID: <20200629095711.4fn2gqlxst2meo4g@u256.net> (raw)
In-Reply-To: <20200625080430.1392037-3-maxime.coquelin@redhat.com>
On 25/06/20 10:04 +0200, Maxime Coquelin wrote:
> This patch makes rte_dev_probe() to return the
> rte_device pointer on success and NULL on error
> instead of returning 0 on success and negative
> value on error.
>
> The goal is to avoid that the calling application
> iterates the devices list afterwards to retrieve
> the pointer. Retrieving the pointer is required
> for calling rte_dev_remove() later.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> app/test-pmd/testpmd.c | 2 +-
> drivers/net/failsafe/failsafe.c | 5 +++--
> lib/librte_eal/common/eal_common_dev.c | 18 ++++++++++--------
> lib/librte_eal/include/rte_dev.h | 4 ++--
> 4 files changed, 16 insertions(+), 13 deletions(-)
>
[...]
> diff --git a/lib/librte_eal/include/rte_dev.h b/lib/librte_eal/include/rte_dev.h
> index c8d985fb5c..9cf7c7fd71 100644
> --- a/lib/librte_eal/include/rte_dev.h
> +++ b/lib/librte_eal/include/rte_dev.h
> @@ -148,9 +148,9 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,
> * @param devargs
> * Device arguments including bus, class and driver properties.
> * @return
> - * 0 on success, negative on error.
> + * Generic device pointer on success, NULL on error.
Hello Maxime,
Do you plan on a v3 with rte_errno support in the new API or do you
prefer to keep it this way after all?
--
Gaëtan
next prev parent reply other threads:[~2020-06-29 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 8:04 [dpdk-dev] [PATCH v2 0/2] rte_dev_probe() API change Maxime Coquelin
2020-06-25 8:04 ` [dpdk-dev] [PATCH v2 1/2] doc: announce " Maxime Coquelin
2020-07-31 7:20 ` Maxime Coquelin
2020-07-31 9:26 ` Bruce Richardson
2020-07-31 9:44 ` Gaëtan Rivet
2020-07-31 9:47 ` Maxime Coquelin
2020-08-04 8:12 ` David Marchand
2020-08-04 8:53 ` Jerin Jacob
2020-06-25 8:04 ` [dpdk-dev] [PATCH v2 (v20.11) 2/2] eal: improve device probing API Maxime Coquelin
2020-06-29 9:57 ` Gaëtan Rivet [this message]
2020-08-05 23:33 ` Thomas Monjalon
2020-08-06 10:29 ` Maxime Coquelin
2020-08-06 11:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629095711.4fn2gqlxst2meo4g@u256.net \
--to=grive@u256.net \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).