DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd
Date: Mon, 29 Jun 2020 14:03:14 +0100
Message-ID: <20200629130314.GD572@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8x64OB7tuOx0ivMRxpsmXtitOub-B0aJiBtor2hG73rvg@mail.gmail.com>

On Mon, Jun 29, 2020 at 12:09:20PM +0200, David Marchand wrote:
> On Wed, May 27, 2020 at 4:58 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > If the bonding pmd is disabled, all autotest associated with it should be
> > disabled. However, some of those tests also depended upon the ring PMD so
> > were placed in a block depending on that driver - and unfortunately that
> > driver alone. This caused build failures if the ring PMD was enabled but
> > the bonding PMD disabled, due to missing header files and driver libs.
> >
> > This error can be reproduced by configuring DPDK using e.g.
> >
> >   meson configure -Ddisable_drivers=net/[!r]* build
> >
> > (which will disable all drivers not starting with "r"), and then building
> > using ninja.
> >
> > Fix this by moving all link bonding autotests to the one block and putting
> > a second conditional check within that block for those also requiring the
> > ring PMD.
> >
> > Fixes: 7f6ef1664027 ("test/bonding: allow disabling driver")
> > Fixes: 207b1c813f39 ("test: fix build without ring PMD")
> > Cc: reshma.pattan@intel.com
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> >  app/test/meson.build | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/meson.build b/app/test/meson.build
> > index 1715ddbcb..dc2474699 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -350,6 +350,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
> >         test_deps += 'pmd_bond'
> >         test_sources += ['test_link_bonding.c', 'test_link_bonding_rssconf.c']
> >         driver_test_names += ['link_bonding_autotest', 'link_bonding_rssconf_autotest']
> > +       if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
> > +               test_sources += 'test_link_bonding_mode4.c'
> > +               driver_test_names += 'link_bonding_mode4_autotest'
> > +       endif
> >  endif
> >  if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
> >         test_deps += 'pmd_ring'
> > @@ -358,7 +362,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
> >         test_sources += 'test_event_eth_tx_adapter.c'
> >         test_sources += 'test_bitratestats.c'
> >         test_sources += 'test_latencystats.c'
> > -       test_sources += 'test_link_bonding_mode4.c'
> >         test_sources += 'sample_packet_forward.c'
> >         test_sources += 'test_pdump.c'
> >         fast_tests += [['ring_pmd_autotest', true]]
> > @@ -366,7 +369,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
> >         fast_tests += [['event_eth_tx_adapter_autotest', false]]
> >         fast_tests += [['bitratestats_autotest', true]]
> >         fast_tests += [['latencystats_autotest', true]]
> > -       driver_test_names += 'link_bonding_mode4_autotest'
> >         fast_tests += [['pdump_autotest', true]]
> >  endif
> >
> > --
> > 2.25.1
> >
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Just a note.
> Looking at the makefile counterpart, I can see that if we disable the
> null driver, we would have an issue too.
> 
I'm not actually seeing an error with it in meson builds. Running a quick
test using build parameter "-Ddisable_drivers=net/null" shows no errors, so
I think we may be ok here. 

Regards,
/Bruce

  reply	other threads:[~2020-06-29 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 14:57 Bruce Richardson
2020-06-29 10:09 ` David Marchand
2020-06-29 13:03   ` Bruce Richardson [this message]
2020-07-01  7:50     ` David Marchand
2020-07-01  9:11   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629130314.GD572@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git