From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E8ECA0350; Mon, 29 Jun 2020 15:05:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E15021BEB5; Mon, 29 Jun 2020 15:05:18 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1570D1BEB3 for ; Mon, 29 Jun 2020 15:05:16 +0200 (CEST) IronPort-SDR: 4JoqbVkaao1TpkoOcvRrH2iqkOS8TNNvGuXrB2MnaBHgjpjlQD8EQW5dAP+CFzROSGapYf+1uP B7NadhJzG5QA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="145955405" X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="145955405" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 06:03:19 -0700 IronPort-SDR: 4L/8338HvwSoQZiqps8VeU0xFpr/dgD+VKtTlKGOJx6AFjVY+kzcaNpyAqGpEYb45F6JEQCMtV pe3Tcd10XDIg== X-IronPort-AV: E=Sophos;i="5.75,294,1589266800"; d="scan'208";a="454184994" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.82.47]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Jun 2020 06:03:17 -0700 Date: Mon, 29 Jun 2020 14:03:14 +0100 From: Bruce Richardson To: David Marchand Cc: dev , "Pattan, Reshma" Message-ID: <20200629130314.GD572@bricha3-MOBL.ger.corp.intel.com> References: <20200527145745.4060-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 29, 2020 at 12:09:20PM +0200, David Marchand wrote: > On Wed, May 27, 2020 at 4:58 PM Bruce Richardson > wrote: > > > > If the bonding pmd is disabled, all autotest associated with it should be > > disabled. However, some of those tests also depended upon the ring PMD so > > were placed in a block depending on that driver - and unfortunately that > > driver alone. This caused build failures if the ring PMD was enabled but > > the bonding PMD disabled, due to missing header files and driver libs. > > > > This error can be reproduced by configuring DPDK using e.g. > > > > meson configure -Ddisable_drivers=net/[!r]* build > > > > (which will disable all drivers not starting with "r"), and then building > > using ninja. > > > > Fix this by moving all link bonding autotests to the one block and putting > > a second conditional check within that block for those also requiring the > > ring PMD. > > > > Fixes: 7f6ef1664027 ("test/bonding: allow disabling driver") > > Fixes: 207b1c813f39 ("test: fix build without ring PMD") > > Cc: reshma.pattan@intel.com > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/meson.build | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 1715ddbcb..dc2474699 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -350,6 +350,10 @@ if dpdk_conf.has('RTE_LIBRTE_BOND_PMD') > > test_deps += 'pmd_bond' > > test_sources += ['test_link_bonding.c', 'test_link_bonding_rssconf.c'] > > driver_test_names += ['link_bonding_autotest', 'link_bonding_rssconf_autotest'] > > + if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > > + test_sources += 'test_link_bonding_mode4.c' > > + driver_test_names += 'link_bonding_mode4_autotest' > > + endif > > endif > > if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > > test_deps += 'pmd_ring' > > @@ -358,7 +362,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > > test_sources += 'test_event_eth_tx_adapter.c' > > test_sources += 'test_bitratestats.c' > > test_sources += 'test_latencystats.c' > > - test_sources += 'test_link_bonding_mode4.c' > > test_sources += 'sample_packet_forward.c' > > test_sources += 'test_pdump.c' > > fast_tests += [['ring_pmd_autotest', true]] > > @@ -366,7 +369,6 @@ if dpdk_conf.has('RTE_LIBRTE_RING_PMD') > > fast_tests += [['event_eth_tx_adapter_autotest', false]] > > fast_tests += [['bitratestats_autotest', true]] > > fast_tests += [['latencystats_autotest', true]] > > - driver_test_names += 'link_bonding_mode4_autotest' > > fast_tests += [['pdump_autotest', true]] > > endif > > > > -- > > 2.25.1 > > > > Reviewed-by: David Marchand > > Just a note. > Looking at the makefile counterpart, I can see that if we disable the > null driver, we would have an issue too. > I'm not actually seeing an error with it in meson builds. Running a quick test using build parameter "-Ddisable_drivers=net/null" shows no errors, so I think we may be ok here. Regards, /Bruce