From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E882CA0350; Mon, 29 Jun 2020 19:04:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E41FE1BED0; Mon, 29 Jun 2020 19:04:55 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 17F741BEC6 for ; Mon, 29 Jun 2020 19:04:53 +0200 (CEST) IronPort-SDR: kLRZtDlFG/2t/q+eSyKpDnPrgiriIDlg0skZQAIQpSwFLHjU1wwtaIfL+xtC+jMa10qstmqllN tXJ23Q+dhuvA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="211088906" X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="211088906" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 10:04:43 -0700 IronPort-SDR: xzg+evLdfLpxNP1cWsGzq82phCN3m/YMYEha/Hi3CeOJLq38R8wGl2J3ozhdpWQLTiO+QHFh8j zEPamNxCt8CA== X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="480859690" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.82.47]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 29 Jun 2020 10:04:42 -0700 Date: Mon, 29 Jun 2020 18:04:39 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20200629170439.GF572@bricha3-MOBL.ger.corp.intel.com> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200605225811.26342-1-stephen@networkplumber.org> <20200605225811.26342-2-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200605225811.26342-2-stephen@networkplumber.org> Subject: Re: [dpdk-dev] [RFC v2 01/26] eal: rename terms used for DPDK lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 05, 2020 at 03:57:46PM -0700, Stephen Hemminger wrote: > Replace the old use of master/slave lcore with more inclusive > name of initial/secondary lcore. The old visible API will > stay for now. > > Change master2slave to new init2worker and vice-versa. > > This patch breaks the expected practice for new API's. > The new rte_get_initial_lcore() will not go through the standard > experimental API phase; there is no functional difference > from the previous name. > > Signed-off-by: Stephen Hemminger > --- This patch needs some rebasing as some of the memory functions have moved from eal_memory.c to eal_common_dynmem.c, and the windows code has been updated too. Any further versions of this set can probably have the "RFC" label removed too, as the consensus very much seems to be in favour of this change - it's just a matter of getting the implementation in. One further comment below. /Bruce > lib/librte_eal/common/eal_common_launch.c | 36 ++++++------- > lib/librte_eal/common/eal_common_lcore.c | 11 ++-- > lib/librte_eal/common/eal_common_options.c | 62 +++++++++++----------- > lib/librte_eal/common/eal_options.h | 4 +- > lib/librte_eal/common/eal_private.h | 6 +-- > lib/librte_eal/common/eal_thread.h | 6 +-- > lib/librte_eal/common/rte_random.c | 2 +- > lib/librte_eal/common/rte_service.c | 2 +- > lib/librte_eal/freebsd/eal.c | 24 ++++----- > lib/librte_eal/freebsd/eal_thread.c | 24 ++++----- > lib/librte_eal/include/rte_eal.h | 4 +- > lib/librte_eal/include/rte_eal_trace.h | 4 +- > lib/librte_eal/include/rte_launch.h | 62 ++++++++++++---------- > lib/librte_eal/include/rte_lcore.h | 29 +++++++--- > lib/librte_eal/linux/eal.c | 24 ++++----- > lib/librte_eal/linux/eal_memory.c | 20 +++---- > lib/librte_eal/linux/eal_thread.c | 24 ++++----- > lib/librte_eal/rte_eal_version.map | 1 + > lib/librte_eal/windows/eal.c | 14 ++--- > lib/librte_eal/windows/eal_thread.c | 22 ++++---- > 20 files changed, 204 insertions(+), 177 deletions(-) > > int > -rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned slave_id) > +rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id) > { > int n; > char c = 0; > - int m2s = lcore_config[slave_id].pipe_master2slave[1]; > - int s2m = lcore_config[slave_id].pipe_slave2master[0]; > + int m2s = lcore_config[worker_id].pipe_init2worker[1]; > + int s2m = lcore_config[worker_id].pipe_worker2init[0]; > int rc = -EBUSY; > For completeness sake, these variable names, which appear in multiple places should be renamed too, m2s -> i2w, s2m -> w2i.