From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7621EA0350; Tue, 30 Jun 2020 11:34:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EF3E1BEC0; Tue, 30 Jun 2020 11:34:06 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 30E651BE9E for ; Tue, 30 Jun 2020 11:34:05 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id q5so19391757wru.6 for ; Tue, 30 Jun 2020 02:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=obvQgx+ySq90YeaAgQae+asW/qNF1e7pVb6vME8fBHk=; b=Il8f/ZBu7Qb2Ni2fkJ9ULufkD7fQ9WIpUR4Ef/oKzU5fbdi0JEOauuoFDzahpIz7Kc OK1tdfmDmtq/s9Jj4I3j/8ksdygbcF9UIcMIo3M5zmi76OY5S/0gn1Haspgybvf0UfEM 2eOBETTktqS16uFoXEaMMW2id8gZi/BlYtQR2K5xQILfVNGPVRXcqynZn/Ve+nNHGiwL 4ykVEuHrtukkdDRmhOe1xKCk0MVLPE8ZvLyHnfQV+IzAfxf37bMogpxqj+5HMdIMrdOC WIyowP/YntIeNDAXkHaY2koZ5t8/AEscVJo7c02xzBxgQG8gQaaRMgaIv2W13xeuK/je ATtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=obvQgx+ySq90YeaAgQae+asW/qNF1e7pVb6vME8fBHk=; b=qJ8o4Cxr06LGWSK2Yn7mhOQv0fefHQpfAM1QKdtoEZq/vppQf4+jplTP02Lh3iIawS MqJmvtjHDfAYtoqc9u7xBkVZm9OYd79fRp3zuAicX3IuuxsW4QrRERiime2+f8gW9AEC dlgkL4oWmYTOLyLIHoDNT+CruZkkwUI0xDvxMiy1Ff70ZrkO48XuLV91Hb9lM73hrvn3 Us8Sa5kpbrTG0ZOE6/5uhf6/9MdEKLY672khwZpus/QHrNyl8i9/Weq7nH8A0Q/5/KYb RIqDswQ791mDx1yc9V16VIOweSwYXuB4CpAw8Mzmos1M9KKxdmWE3unNLWJbCpm8Sg4H 28Uw== X-Gm-Message-State: AOAM532G7gSmc+WCkAA8BtDudIQBcrrQYjVT51hlXpRJEiQUmVSqSqMh hC0HQykXd/tWi1yLt3nOoMVs+Q== X-Google-Smtp-Source: ABdhPJxeOTlErwlrDpJsmZcyUKM+Dp7a9vO53C59t26O7ChKnT+nlqNLqx9PTYn1f3Kqp8xQzLYnxA== X-Received: by 2002:a5d:6651:: with SMTP id f17mr22502555wrw.29.1593509644276; Tue, 30 Jun 2020 02:34:04 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a600345636f7e65ed1a0.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:3456:36f7:e65e:d1a0]) by smtp.gmail.com with ESMTPSA id k126sm3040844wmf.3.2020.06.30.02.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 02:34:03 -0700 (PDT) Date: Tue, 30 Jun 2020 11:34:03 +0200 From: Olivier Matz To: David Marchand Cc: dev@dpdk.org, jerinjacobk@gmail.com, bruce.richardson@intel.com, mdr@ashroe.eu, thomas@monjalon.net, arybchenko@solarflare.com, ktraynor@redhat.com, ian.stokes@intel.com, i.maximets@ovn.org, Neil Horman , Cunming Liang , Konstantin Ananyev Message-ID: <20200630093403.GB5869@platinum> References: <20200610144506.30505-1-david.marchand@redhat.com> <20200626144736.11011-1-david.marchand@redhat.com> <20200626144736.11011-3-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626144736.11011-3-david.marchand@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v4 2/9] eal: fix multiple definition of per lcore thread id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 26, 2020 at 04:47:29PM +0200, David Marchand wrote: > Because of the inline accessor + static declaration in rte_gettid(), > we end up with multiple symbols for RTE_PER_LCORE(_thread_id). > Each compilation unit will pay a cost when accessing this information > for the first time. > > $ nm build/app/dpdk-testpmd | grep per_lcore__thread_id > 0000000000000054 d per_lcore__thread_id.5037 > 0000000000000040 d per_lcore__thread_id.5103 > 0000000000000048 d per_lcore__thread_id.5259 > 000000000000004c d per_lcore__thread_id.5259 > 0000000000000044 d per_lcore__thread_id.5933 > 0000000000000058 d per_lcore__thread_id.6261 > 0000000000000050 d per_lcore__thread_id.7378 > 000000000000005c d per_lcore__thread_id.7496 > 000000000000000c d per_lcore__thread_id.8016 > 0000000000000010 d per_lcore__thread_id.8431 > > Make it global as part of the DPDK_21 stable ABI. > > Fixes: ef76436c6834 ("eal: get unique thread id") > > Signed-off-by: David Marchand > Acked-by: Ray Kinsella Reviewed-by: Olivier Matz