From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
Neil Horman <nhorman@tuxdriver.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Gagandeep Singh <g.singh@nxp.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] build: replace meson OS detection with variable
Date: Tue, 30 Jun 2020 13:08:19 +0100 [thread overview]
Message-ID: <20200630120819.GA583@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200629203656.39052-1-thomas@monjalon.net>
On Mon, Jun 29, 2020 at 10:36:56PM +0200, Thomas Monjalon wrote:
> Some places were calling the meson function host_machine.system()
> instead of the variables is_windows and is_linux defined
> in config/meson.build.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
though while changing this it would be good if you could take care of the
one additional comment below also.
> ---
> buildtools/pmdinfogen/meson.build | 2 +-
> drivers/crypto/octeontx2/meson.build | 2 +-
> drivers/net/pfe/meson.build | 2 +-
> examples/ntb/meson.build | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/buildtools/pmdinfogen/meson.build b/buildtools/pmdinfogen/meson.build
> index 7da415b3b7..670528fac7 100644
> --- a/buildtools/pmdinfogen/meson.build
> +++ b/buildtools/pmdinfogen/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -if host_machine.system() == 'windows'
> +if is_windows
> subdir_done()
> endif
>
> diff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build
> index a28c700b9f..e3d34db38a 100644
> --- a/drivers/crypto/octeontx2/meson.build
> +++ b/drivers/crypto/octeontx2/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright (C) 2019 Marvell International Ltd.
>
> -if host_machine.system() != 'linux'
> +if not is_linux
> build = false
> endif
>
This and the other instances below should also set "reason" variable so we
get in the output log at the end why they are not being built. Generally
drivers copy-paste this line:
reason = 'only supported on Linux'
> diff --git a/drivers/net/pfe/meson.build b/drivers/net/pfe/meson.build
> index 3e1a228a3f..6d4b838eb7 100644
> --- a/drivers/net/pfe/meson.build
> +++ b/drivers/net/pfe/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright 2019 NXP
>
> -if host_machine.system() != 'linux'
> +if not is_linux
> build = false
> endif
> deps += ['common_dpaax']
> diff --git a/examples/ntb/meson.build b/examples/ntb/meson.build
> index ab449d0939..45a59350c5 100644
> --- a/examples/ntb/meson.build
> +++ b/examples/ntb/meson.build
> @@ -7,7 +7,7 @@
> # DPDK instance, use 'make'
>
> allow_experimental_apis = true
> -if host_machine.system() != 'linux'
> +if not is_linux
> build = false
> endif
> deps += 'rawdev'
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-06-30 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 20:36 Thomas Monjalon
2020-06-30 12:08 ` Bruce Richardson [this message]
2020-06-30 13:15 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-06-30 13:23 ` Bruce Richardson
2020-06-30 13:28 ` Akhil Goyal
2020-06-30 13:32 ` Thomas Monjalon
2020-07-01 4:05 ` [dpdk-dev] [EXT] " Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630120819.GA583@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=jingjing.wu@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).