From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, ktraynor@redhat.com, bluca@debian.org, sunil.pai.g@intel.com, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking Date: Tue, 30 Jun 2020 15:14:33 +0100 Message-ID: <20200630141433.818517-8-bruce.richardson@intel.com> (raw) In-Reply-To: <20200630141433.818517-1-bruce.richardson@intel.com> Add the --as-needed linker flag to the DPDK library list in the pkg-config file so as to prevent overlinking. Without this flag, when linking statically using flags from $(pkg-config --static --libs libdpdk), all DPDK drivers and libs were statically linked in, but the binary was also requiring all the shared versions be present to run. The real root-cause of this issue is that the DPDK libraries need to be duplicated in the linker command when doing static linking, due to the behaviour of pkg-config, but since that behaviour cannot be easily changed, this is a simple workaround to avoid problems. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Luca Boccassi <bluca@debian.org> Acked-by: Sunil Pai G <sunil.pai.g@intel.com> --- buildtools/pkg-config/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build index e043c5ee1..5c1e31c4d 100644 --- a/buildtools/pkg-config/meson.build +++ b/buildtools/pkg-config/meson.build @@ -23,7 +23,7 @@ Use libdpdk.pc instead of this file to query DPDK compile/link arguments''', version: meson.project_version(), subdirs: [get_option('include_subdir_arch'), '.'], extra_cflags: pkg_extra_cflags, - libraries: dpdk_libraries, + libraries: ['-Wl,--as-needed'] + dpdk_libraries, libraries_private: dpdk_extra_ldflags) pkg.generate(name: 'DPDK', # main DPDK pkgconfig file -- 2.25.1
next prev parent reply other threads:[~2020-06-30 14:16 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 10:08 [dpdk-dev] [PATCH 0/7] improve DPDK static builds with meson Bruce Richardson 2020-04-29 10:08 ` [dpdk-dev] [PATCH 1/7] build: always link-whole DPDK static libraries Bruce Richardson 2020-04-29 10:18 ` Thomas Monjalon 2020-04-29 10:42 ` Bruce Richardson 2020-04-29 10:49 ` Thomas Monjalon 2020-04-29 14:04 ` Andrzej Ostruszka [C] 2020-04-29 10:08 ` [dpdk-dev] [PATCH 2/7] build: remove unnecessary variable Bruce Richardson 2020-04-29 10:19 ` Thomas Monjalon 2020-04-29 10:29 ` Bruce Richardson 2020-04-29 10:08 ` [dpdk-dev] [PATCH 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson 2020-04-29 10:08 ` [dpdk-dev] [PATCH 4/7] build: move pkg-config creation to separate file Bruce Richardson 2020-04-29 10:08 ` [dpdk-dev] [PATCH 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson 2020-04-29 10:30 ` Thomas Monjalon 2020-04-29 10:54 ` Bruce Richardson 2020-04-29 10:40 ` Luca Boccassi 2020-04-29 11:03 ` Bruce Richardson 2020-04-29 11:12 ` Luca Boccassi 2020-04-29 10:08 ` [dpdk-dev] [PATCH 6/7] build/pkg-config: improve static linking flags Bruce Richardson 2020-04-29 10:32 ` Thomas Monjalon 2020-04-29 10:56 ` Bruce Richardson 2020-04-29 10:57 ` Thomas Monjalon 2020-04-29 10:37 ` Luca Boccassi 2020-04-29 10:58 ` Bruce Richardson 2020-04-29 11:10 ` Luca Boccassi 2020-04-29 10:08 ` [dpdk-dev] [PATCH 7/7] build/pkg-config: prevent overlinking Bruce Richardson 2020-04-29 10:34 ` Thomas Monjalon 2020-04-29 11:00 ` Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 1/7] build: always link-whole DPDK static libraries Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 2/7] build: remove unnecessary variable Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 4/7] build: move pkg-config creation to separate file Bruce Richardson 2020-05-01 13:53 ` [dpdk-dev] [PATCH v2 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson 2020-05-01 13:54 ` [dpdk-dev] [PATCH v2 6/7] build/pkg-config: improve static linking flags Bruce Richardson 2020-05-01 13:54 ` [dpdk-dev] [PATCH v2 7/7] build/pkg-config: prevent overlinking Bruce Richardson 2020-05-01 14:02 ` [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson Luca Boccassi 2020-06-30 13:25 ` Pai G, Sunil 2020-06-30 16:37 ` Stokes, Ian 2020-07-01 17:29 ` Thomas Monjalon 2020-07-02 10:46 ` Stokes, Ian 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 " Bruce Richardson 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 1/7] build: always link-whole DPDK static libraries Bruce Richardson 2020-07-01 14:19 ` Thomas Monjalon 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 2/7] build: remove unnecessary variable Bruce Richardson 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 3/7] devtools/test-meson-builds.sh: add pkg-config static builds Bruce Richardson 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 4/7] build: move pkg-config creation to separate file Bruce Richardson 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 5/7] build/pkg-config: output driver libs first for static build Bruce Richardson 2020-07-01 7:50 ` Thomas Monjalon 2020-07-01 8:43 ` Bruce Richardson 2020-07-01 14:42 ` Thomas Monjalon 2020-07-01 15:16 ` Bruce Richardson 2020-07-01 15:36 ` Thomas Monjalon 2020-07-01 15:45 ` Bruce Richardson 2020-07-01 16:04 ` Thomas Monjalon 2020-06-30 14:14 ` [dpdk-dev] [PATCH v3 6/7] build/pkg-config: improve static linking flags Bruce Richardson 2020-07-01 14:30 ` Thomas Monjalon 2020-07-01 14:33 ` Thomas Monjalon 2020-07-01 14:36 ` Bruce Richardson 2020-07-01 14:45 ` Thomas Monjalon 2020-06-30 14:14 ` Bruce Richardson [this message] 2020-07-01 7:56 ` [dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking Thomas Monjalon 2020-07-01 8:58 ` Bruce Richardson 2020-07-01 17:33 ` [dpdk-dev] [PATCH v3 0/7] improve DPDK static builds with meson Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200630141433.818517-8-bruce.richardson@intel.com \ --to=bruce.richardson@intel.com \ --cc=bluca@debian.org \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=ktraynor@redhat.com \ --cc=sunil.pai.g@intel.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git