From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrey Vesnovaty <andrey.vesnovaty@gmail.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ori Kam <orika@mellanox.com>,
dev@dpdk.org, Andrey Vesnovaty <andreyv@mellanox.com>
Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API
Date: Wed, 1 Jul 2020 17:24:09 -0700 [thread overview]
Message-ID: <20200701172409.6b82bd6e@hermes.lan> (raw)
In-Reply-To: <20200620133257.12441-1-andrey.vesnovaty@gmail.com>
On Sat, 20 Jun 2020 16:32:57 +0300
Andrey Vesnovaty <andrey.vesnovaty@gmail.com> wrote:
> +
> +void *
> +rte_flow_shared_action_create(uint16_t port_id,
> + const struct rte_flow_action *action,
> + struct rte_flow_error *error)
> +{
NAK
API's that return void * (opaque pointer) are dangerous and should
not be added to DPDK.
To do data hiding. Define a structure but don't expose the internals
of what that structure are.
next prev parent reply other threads:[~2020-07-02 0:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 9:18 [dpdk-dev] [RFC] add flow action context API Andrey Vesnovaty
2020-06-03 10:02 ` Thomas Monjalon
2020-06-04 11:12 ` Andrey Vesnovaty
2020-06-04 17:23 ` Thomas Monjalon
2020-06-05 8:30 ` Bruce Richardson
2020-06-05 8:33 ` Thomas Monjalon
2020-06-03 10:53 ` Jerin Jacob
2020-06-04 11:25 ` Andrey Vesnovaty
2020-06-04 12:36 ` Jerin Jacob
2020-06-04 15:57 ` Andrey Vesnovaty
2020-06-09 16:01 ` Jerin Jacob
2020-06-20 13:32 ` [dpdk-dev] [RFC v2 0/1] " Andrey Vesnovaty
2020-06-22 15:22 ` Thomas Monjalon
2020-06-22 17:09 ` Andrey Vesnovaty
2020-06-26 11:44 ` Jerin Jacob
2020-06-28 8:44 ` Andrey Vesnovaty
2020-06-28 13:42 ` Jerin Jacob
2020-06-29 10:22 ` Andrey Vesnovaty
2020-06-30 9:52 ` Jerin Jacob
2020-07-01 9:24 ` Andrey Vesnovaty
2020-07-01 10:34 ` Jerin Jacob
2020-06-20 13:32 ` [dpdk-dev] [RFC v2 1/1] add flow shared action API Andrey Vesnovaty
2020-07-02 0:24 ` Stephen Hemminger [this message]
2020-07-02 7:20 ` Ori Kam
2020-07-02 8:06 ` Andrey Vesnovaty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701172409.6b82bd6e@hermes.lan \
--to=stephen@networkplumber.org \
--cc=andrey.vesnovaty@gmail.com \
--cc=andreyv@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).