From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D980A0523; Thu, 2 Jul 2020 02:24:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55E311D5C9; Thu, 2 Jul 2020 02:24:20 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 8FD6C1D5C8 for ; Thu, 2 Jul 2020 02:24:18 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id d10so10561375pls.5 for ; Wed, 01 Jul 2020 17:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8d67R+3KhBBr05cUOVuIJhOF0R4C2ULtDMU+WF0wQ3s=; b=ibmLv3RHjpSU2c1ssxhQdFoPZ6JpCZ9SbVwyMeQy/JBTgK37cnpPqhto1q8Y/oALQ7 1puGiTuu3hVMVjg2i5BGwEQN38HXh8D4sqQwJvv/rFp6hr9wy8mSmTbNIRawi6mks7ev YJsVUau2Xlq7ZojR+RI3912bh7tvd8i9I9mi8jmUkO9W/f6EWcIZBlk41G3Cp1vioPuX RQXWSCX64SeFqwSQVfIwd/oEyqD5Q6DRRhTPjZ2NQzyVHoyEKA6ZSVAZB6sgt1qGh0e3 EwuQAvB6Fa75khGmTA7MeZitzooc4AnuN4Ii06dRrRzyg8Mcv6D0XaMpifoGQSqF/v7r oj8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8d67R+3KhBBr05cUOVuIJhOF0R4C2ULtDMU+WF0wQ3s=; b=izXidPTooJEq//K+wEoShhcb9/h93VUdk8VcukcOL3NmW7/3YLSeHTylkc5oZKjuBj ljCORgkBb0tyUuT0c3YmLNGJ1WCSt8Gvop3l1ECrUv3vfW+h70FIWfaU02tJHUx64YRB EJJ9Kw3oLmh/REJTbmwHJJ50G73DaktjIl0VdUH/c1GUFeYDtefK8Ho/VK6O1ydBhWCm h0H40k2kNSVG2araDdxGc2B12iuoHT6b74Qm3x529+oXAjojY++2TJlWLq0gjYbucvOT QNPZb0t2WOC46Sbmhm/RhhH6iBbGv2S67qFoFEit3Rtf8ZH8V9+U0dnnt39usaEF/+3N rObA== X-Gm-Message-State: AOAM530mRaCzcXZX4XsDBZdHmMdGJRSMCcRCn4uPy7VFLFK9NdqumFkF 2z5vK8CMYHHIJPSz3IkHXqreLA== X-Google-Smtp-Source: ABdhPJzkCXVF98Kb4kt44zHx1cSIcoDmBDgIjeCwYKLYtb3Y8Yov1odktSg+kaR5P15PE5vMc/Hk0g== X-Received: by 2002:a17:902:ff12:: with SMTP id f18mr24384641plj.173.1593649457592; Wed, 01 Jul 2020 17:24:17 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f14sm6926554pgj.62.2020.07.01.17.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 17:24:17 -0700 (PDT) Date: Wed, 1 Jul 2020 17:24:09 -0700 From: Stephen Hemminger To: Andrey Vesnovaty Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ori Kam , dev@dpdk.org, Andrey Vesnovaty Message-ID: <20200701172409.6b82bd6e@hermes.lan> In-Reply-To: <20200620133257.12441-1-andrey.vesnovaty@gmail.com> References: <20200620133257.12441-1-andrey.vesnovaty@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 20 Jun 2020 16:32:57 +0300 Andrey Vesnovaty wrote: > + > +void * > +rte_flow_shared_action_create(uint16_t port_id, > + const struct rte_flow_action *action, > + struct rte_flow_error *error) > +{ NAK API's that return void * (opaque pointer) are dangerous and should not be added to DPDK. To do data hiding. Define a structure but don't expose the internals of what that structure are.