From: <pbhagavatula@marvell.com>
To: <jerinj@marvell.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [dpdk-dev] [PATCH (v20.11) 1/2] eventdev: reserve space in config structs for extension
Date: Thu, 2 Jul 2020 11:49:49 +0530 [thread overview]
Message-ID: <20200702061951.1663-1-pbhagavatula@marvell.com> (raw)
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Reserve space in event device configuration structures as increasing their
size would break ABI for some applications.
In order to allow smooth addition of features without breaking
ABI compatibility, reserve some space.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/librte_eventdev/rte_event_crypto_adapter.h | 4 ++++
lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 ++++++++
lib/librte_eventdev/rte_event_eth_tx_adapter.h | 4 ++++
lib/librte_eventdev/rte_event_timer_adapter.h | 8 ++++++++
lib/librte_eventdev/rte_eventdev.h | 16 ++++++++++++++++
5 files changed, 40 insertions(+)
diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.h b/lib/librte_eventdev/rte_event_crypto_adapter.h
index 60630ef66..c471ece79 100644
--- a/lib/librte_eventdev/rte_event_crypto_adapter.h
+++ b/lib/librte_eventdev/rte_event_crypto_adapter.h
@@ -250,6 +250,10 @@ struct rte_event_crypto_adapter_conf {
* max_nb crypto ops. This isn't treated as a requirement; batching
* may cause the adapter to process more than max_nb crypto ops.
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
index 2dd259c27..d10f632e9 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
@@ -112,6 +112,10 @@ struct rte_event_eth_rx_adapter_conf {
* max_nb_rx mbufs. This isn't treated as a requirement; batching may
* cause the adapter to process more than max_nb_rx mbufs.
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
@@ -171,6 +175,10 @@ struct rte_event_eth_rx_adapter_queue_conf {
* The event adapter sets ev.event_type to RTE_EVENT_TYPE_ETHDEV in the
* enqueued event.
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.h b/lib/librte_eventdev/rte_event_eth_tx_adapter.h
index 8c5954716..442e54da4 100644
--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.h
+++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.h
@@ -97,6 +97,10 @@ struct rte_event_eth_tx_adapter_conf {
* max_nb_tx mbufs. This isn't treated as a requirement; batching may
* cause the adapter to process more than max_nb_tx mbufs.
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h
index d2ebcb090..f83d85f4d 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.h
+++ b/lib/librte_eventdev/rte_event_timer_adapter.h
@@ -171,6 +171,10 @@ struct rte_event_timer_adapter_conf {
/**< Total number of timers per adapter */
uint64_t flags;
/**< Timer adapter config flags (RTE_EVENT_TIMER_ADAPTER_F_*) */
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
@@ -268,6 +272,10 @@ struct rte_event_timer_adapter_info {
/**< Event timer adapter capabilities */
int16_t event_dev_port_id;
/**< Event device port ID, if applicable */
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
index 7dc832353..1effeed58 100644
--- a/lib/librte_eventdev/rte_eventdev.h
+++ b/lib/librte_eventdev/rte_eventdev.h
@@ -387,6 +387,10 @@ struct rte_event_dev_info {
*/
uint32_t event_dev_cap;
/**< Event device capabilities(RTE_EVENT_DEV_CAP_)*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
@@ -494,6 +498,10 @@ struct rte_event_dev_config {
*/
uint32_t event_dev_cfg;
/**< Event device config flags(RTE_EVENT_DEV_CFG_)*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
@@ -574,6 +582,10 @@ struct rte_event_queue_conf {
* event device supported priority value.
* Valid when the device has RTE_EVENT_DEV_CAP_QUEUE_QOS capability
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
@@ -705,6 +717,10 @@ struct rte_event_port_conf {
* RTE_EVENT_OP_FORWARD. Must be false when the device is not
* RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capable.
*/
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields. */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields. */
};
/**
--
2.17.1
next reply other threads:[~2020-07-02 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 6:19 pbhagavatula [this message]
2020-07-02 6:19 ` [dpdk-dev] [PATCH (v20.11) 2/2] eventdev: reserve space in timer " pbhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702061951.1663-1-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).