From: <pbhagavatula@marvell.com>
To: <jerinj@marvell.com>, Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Cc: <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [dpdk-dev] [PATCH (v20.11) 2/2] eventdev: reserve space in timer structs for extension
Date: Thu, 2 Jul 2020 11:49:50 +0530 [thread overview]
Message-ID: <20200702061951.1663-2-pbhagavatula@marvell.com> (raw)
In-Reply-To: <20200702061951.1663-1-pbhagavatula@marvell.com>
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
The struct rte_event_timer_adapter and rte_event_timer_adapter_data are
supposed to be used internally only, but there is a chance that
increasing their size would break ABI for some applications.
In order to allow smooth addition of features without breaking
ABI compatibility, reserve some space.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
lib/librte_eventdev/rte_event_timer_adapter.h | 5 +++++
lib/librte_eventdev/rte_event_timer_adapter_pmd.h | 5 +++++
2 files changed, 10 insertions(+)
diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h
index f83d85f4d..ce57a990a 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter.h
+++ b/lib/librte_eventdev/rte_event_timer_adapter.h
@@ -529,6 +529,11 @@ struct rte_event_timer_adapter {
RTE_STD_C11
uint8_t allocated : 1;
/**< Flag to indicate that this adapter has been allocated */
+
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields */
} __rte_cache_aligned;
#define ADAPTER_VALID_OR_ERR_RET(adapter, retval) do { \
diff --git a/lib/librte_eventdev/rte_event_timer_adapter_pmd.h b/lib/librte_eventdev/rte_event_timer_adapter_pmd.h
index cf3509dc6..0a6682833 100644
--- a/lib/librte_eventdev/rte_event_timer_adapter_pmd.h
+++ b/lib/librte_eventdev/rte_event_timer_adapter_pmd.h
@@ -105,6 +105,11 @@ struct rte_event_timer_adapter_data {
RTE_STD_C11
uint8_t started : 1;
/**< Flag to indicate adapter started. */
+
+ uint64_t reserved_64s[4];
+ /**< Reserved for future fields */
+ void *reserved_ptrs[4];
+ /**< Reserved for future fields */
} __rte_cache_aligned;
#ifdef __cplusplus
--
2.17.1
prev parent reply other threads:[~2020-07-02 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 6:19 [dpdk-dev] [PATCH (v20.11) 1/2] eventdev: reserve space in config " pbhagavatula
2020-07-02 6:19 ` pbhagavatula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702061951.1663-2-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).