DPDK patches and discussions
 help / color / mirror / Atom feed
From: Louise Kilheeney <louise.kilheeney@intel.com>
To: dev@dpdk.org
Cc: robin.jarry@6wind.com, anatoly.burakov@intel.com,
	bruce.richardson@intel.com,
	Louise Kilheeney <louise.kilheeney@intel.com>
Subject: [dpdk-dev] [PATCH v3 2/9] usertools/dpdk-devbind: support python3 only
Date: Thu,  2 Jul 2020 11:37:05 +0100	[thread overview]
Message-ID: <20200702103712.13992-3-louise.kilheeney@intel.com> (raw)
In-Reply-To: <20200702103712.13992-1-louise.kilheeney@intel.com>

Changed script to explicitly use python3 only to avoid
maintaining python 2.

Signed-off-by: Louise Kilheeney <louise.kilheeney@intel.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

---
v3: removed extra white space
v2: removed check_output function as not required for python3.
---
 usertools/dpdk-devbind.py | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index dc008823f..3e7d525e8 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -1,9 +1,8 @@
-#! /usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 #
 
-from __future__ import print_function
 import sys
 import os
 import getopt
@@ -143,14 +142,6 @@ def usage():
 
     """ % locals())  # replace items from local variables
 
-
-# This is roughly compatible with check_output function in subprocess module
-# which is only available in python 2.7.
-def check_output(args, stderr=None):
-    '''Run a command and capture its output'''
-    return subprocess.Popen(args, stdout=subprocess.PIPE,
-                            stderr=stderr).communicate()[0]
-
 # check if a specific kernel module is loaded
 def module_is_loaded(module):
     global loaded_modules
@@ -207,7 +198,7 @@ def get_pci_device_details(dev_id, probe_lspci):
     device = {}
 
     if probe_lspci:
-        extra_info = check_output(["lspci", "-vmmks", dev_id]).splitlines()
+        extra_info = subprocess.check_output(["lspci", "-vmmks", dev_id]).splitlines()
 
         # parse lspci details
         for line in extra_info:
@@ -244,7 +235,7 @@ def get_device_details(devices_type):
     # first loop through and read details for all devices
     # request machine readable format, with numeric IDs and String
     dev = {}
-    dev_lines = check_output(["lspci", "-Dvmmnnk"]).splitlines()
+    dev_lines = subprocess.check_output(["lspci", "-Dvmmnnk"]).splitlines()
     for dev_line in dev_lines:
         if len(dev_line) == 0:
             if device_type_match(dev, devices_type):
@@ -272,7 +263,7 @@ def get_device_details(devices_type):
         # check what is the interface if any for an ssh connection if
         # any to this host, so we can mark it later.
         ssh_if = []
-        route = check_output(["ip", "-o", "route"])
+        route = subprocess.check_output(["ip", "-o", "route"])
         # filter out all lines for 169.254 routes
         route = "\n".join(filter(lambda ln: not ln.startswith("169.254"),
                              route.decode().splitlines()))
-- 
2.17.1


  parent reply	other threads:[~2020-07-02 10:37 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 13:23 [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-05-26 18:58   ` Chautru, Nicolas
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-05-28 12:39   ` Burakov, Anatoly
2020-05-28 12:41     ` Burakov, Anatoly
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 6/9] app/test-cmdline: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 7/9] app/test: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 8/9] devtools: " Louise Kilheeney
2020-05-27  6:15   ` Ray Kinsella
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 9/9] config/arm: " Louise Kilheeney
2020-05-22 13:46   ` Thomas Monjalon
2020-05-22 14:10     ` Kilheeney, Louise
2020-05-23 21:27       ` Thomas Monjalon
2020-05-25  9:53         ` Bruce Richardson
2020-06-25  9:34           ` Harman Kalra
2020-05-25  7:27 ` [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only Robin Jarry
2020-05-25  9:51   ` Bruce Richardson
2020-05-25 10:29     ` Robin Jarry
2020-05-25 10:56   ` Kilheeney, Louise
2020-05-25 11:06     ` Robin Jarry
2020-06-17 15:10 ` [dpdk-dev] [PATCH v2 " Louise Kilheeney
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-06-25 12:46     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-06-25 12:48     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-06-25 12:49     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-06-17 17:19     ` Neil Horman
2020-07-02 11:23     ` Neil Horman
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-06-25 12:49     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 6/9] app/test-cmdline: " Louise Kilheeney
2020-06-26  9:28     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 7/9] app/test: " Louise Kilheeney
2020-06-26  9:30     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 8/9] devtools: " Louise Kilheeney
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 9/9] config/arm: " Louise Kilheeney
2020-06-26  9:31     ` Burakov, Anatoly
2020-07-02 10:37 ` [dpdk-dev] [PATCH v3 0/9] dding support for python 3 only Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-07-02 10:37   ` Louise Kilheeney [this message]
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 6/9] app/test-cmdline: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 7/9] app/test: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 8/9] devtools: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 9/9] config/arm: " Louise Kilheeney
2020-07-08  8:59   ` [dpdk-dev] [PATCH v3 0/9] dding support for python 3 only David Marchand
2020-07-08 10:13     ` Kilheeney, Louise
2020-08-04 14:07 ` [dpdk-dev] [PATCH v4 0/9] adding " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 1/9] usertools/dpdk-telemetry-client: support python3 only Louise Kilheeney
2020-08-05  9:10     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-08-12 14:27     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 3/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-08-12 14:44     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 4/9] usertools/cpu_layout: " Louise Kilheeney
2020-08-12 14:49     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 5/9] app/test-cmdline: " Louise Kilheeney
2020-08-12 15:05     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 6/9] app/test: " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 7/9] devtools: " Louise Kilheeney
2020-08-05  8:44     ` Kinsella, Ray
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 8/9] config/arm: " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 9/9] app/test-bbdev: " Louise Kilheeney
2020-08-21  9:14 ` [dpdk-dev] [PATCH v5 0/9]adding support for python 3 only Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 1/9] usertools/dpdk-telemetry-client: support python3 only Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 3/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-08-21 12:42     ` Neil Horman
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 4/9] usertools/cpu_layout: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 5/9] app/test-cmdline: " Louise Kilheeney
2020-08-21  9:24     ` Bruce Richardson
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 6/9] app/test: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 7/9] devtools: " Louise Kilheeney
2020-08-21 12:42     ` Neil Horman
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 8/9] config/arm: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 9/9] app/test-bbdev: " Louise Kilheeney
2020-09-15 14:11   ` [dpdk-dev] [PATCH v5 0/9]adding support for python 3 only David Marchand
2020-09-21 11:46   ` [dpdk-dev] [PATCH v6 00/10] adding " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 05/10] app/test-cmdline: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 06/10] app/test: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 07/10] devtools: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 08/10] config/arm: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 09/10] app/test-bbdev: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 10/10] buildtools: " Kevin Laatz
2020-09-21 12:03     ` [dpdk-dev] [PATCH v7 00/10] adding support for python 3 only Kevin Laatz
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-25 14:32         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-25 14:49         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-25 14:50         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-25 14:51         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 05/10] app/test-cmdline: " Kevin Laatz
2020-09-25 14:52         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 06/10] app/test: " Kevin Laatz
2020-09-25 14:54         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 07/10] devtools: " Kevin Laatz
2020-09-25 14:55         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 08/10] config/arm: " Kevin Laatz
2020-09-25 14:55         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 09/10] app/test-bbdev: " Kevin Laatz
2020-09-25 14:56         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 10/10] buildtools: " Kevin Laatz
2020-09-25 14:56         ` Robin Jarry
2020-09-28 10:43       ` [dpdk-dev] [PATCH v8 00/10] adding support for python 3 only Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-28 11:24           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-28 11:25           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-28 11:25           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-28 11:26           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 05/10] app/test-cmdline: " Kevin Laatz
2020-09-28 11:27           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 06/10] app/test: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 07/10] devtools: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 08/10] config/arm: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 09/10] app/test-bbdev: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 10/10] buildtools: " Kevin Laatz
2020-09-28 11:23           ` Robin Jarry
2020-09-28 11:29         ` [dpdk-dev] [PATCH v8 00/10] adding support for python 3 only Robin Jarry
2020-09-28 15:09           ` Bruce Richardson
2020-09-28 15:09         ` David Marchand
2020-09-28 15:14           ` Bruce Richardson
2020-09-28 15:36             ` Kevin Laatz
2020-09-29 10:22         ` [dpdk-dev] [PATCH v9 00/11] " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 01/11] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 02/11] usertools/dpdk-devbind: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 03/11] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 04/11] usertools/cpu_layout: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 05/11] app/test-cmdline: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 06/11] app/test: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 07/11] devtools: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 08/11] config/arm: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 09/11] app/test-bbdev: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 10/11] buildtools: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 11/11] doc: " Kevin Laatz
2020-09-30  8:18             ` Kinsella, Ray
2020-09-29 12:22           ` [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only David Marchand
2020-09-29 15:25             ` Kevin Laatz
2020-09-29 15:48               ` Bruce Richardson
2020-09-29 15:54                 ` Robin Jarry
2020-09-29 16:33                   ` Bruce Richardson
2020-09-29 14:40           ` Stephen Hemminger
2020-09-30 11:40           ` [dpdk-dev] [PATCH v10 " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 01/11] usertools/dpdk-telemetry: support python3 only Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 02/11] usertools/dpdk-devbind: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 03/11] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 04/11] usertools/cpu_layout: " Kevin Laatz
2020-10-02  9:51               ` David Marchand
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 05/11] app/test-cmdline: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 06/11] app/test: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 07/11] devtools: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 08/11] config/arm: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 09/11] app/test-bbdev: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 10/11] buildtools: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 11/11] doc: " Kevin Laatz
2020-10-02 11:01               ` David Marchand
2020-10-02 11:07                 ` Kevin Laatz
2020-10-02 11:18                 ` Bruce Richardson
2020-10-02 12:54             ` [dpdk-dev] [PATCH v10 00/11] adding support for python 3 only David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702103712.13992-3-louise.kilheeney@intel.com \
    --to=louise.kilheeney@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=robin.jarry@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).