From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62650A0520; Thu, 2 Jul 2020 13:02:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBC7D1D962; Thu, 2 Jul 2020 13:02:00 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 594B11D95E; Thu, 2 Jul 2020 13:01:59 +0200 (CEST) IronPort-SDR: +kcNjdFAHXiys5106IE4mzo/f4DoSLV+DttBhyffweAE89Qdq0twZmz6OiDhqaSVA15arqxOwW JYYPjdAExiGw== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="146860883" X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="146860883" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 04:01:58 -0700 IronPort-SDR: YAyOXeTx7jGIlpawo3RPEH+NJNAkf8S25Vm+ApGbHFImW24ToJk4TC/X6yXMLU9pqDKh65egkv +M4c27aAxfBg== X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="455488100" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.120]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Jul 2020 04:01:57 -0700 Date: Thu, 2 Jul 2020 12:01:54 +0100 From: Bruce Richardson To: Timothy Redaelli Cc: dev@dpdk.org, harry.van.haaren@intel.com, stable@dpdk.org Message-ID: <20200702110154.GE611@bricha3-MOBL.ger.corp.intel.com> References: <18f843ba879918cf02416f428bb810e7ea8cde10.1593623742.git.tredaelli@redhat.com> <20200702091648.GA611@bricha3-MOBL.ger.corp.intel.com> <20200702124206.76a2cbc2@aldebaran> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702124206.76a2cbc2@aldebaran> Subject: Re: [dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 02, 2020 at 12:42:06PM +0200, Timothy Redaelli wrote: > On Thu, 2 Jul 2020 10:16:48 +0100 > Bruce Richardson wrote: > > > On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote: > > > This commit fixes the setting of relative rpath on dpdk-test for > > > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath > > > ($prefix$libdir/dpdk/pmd-$abiver) > > > > > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") > > > Cc: harry.van.haaren@intel.com > > > Cc: stable@dpdk.org > > > Signed-off-by: Timothy Redaelli > > > --- > > > app/test/meson.build | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > I'm not sure I agree with this change. It's better to have a relative > > rather than absolute rpath, I think. What problems is it causing to have a > > relative vs absolute rpath? > > > > I only backported the same fix done in app/meson.build since, > currently, app/test/meson.build adds a rpath to "lib64/dpdk/pmd-20.0" > that doesn't exists since, in this case, it should be > "../lib64/dpdk/pmd-20.0" on Fedora, or > "../lib/x86_64-linux-gnu/dpdk/pmds-20.0" on Debian. > > If we want relative paths we should change "install_rpath:" line on > app/meson.build too. > > Debian workarounded that bug by stripping rpaths from dpdk-test [1], > but I'd like to avoid doing that on Fedora/RHEL too, when we'll > migrate to meson, since currently check-rpaths (invoked by rpmbuild) is > complaining about the invalid rpath: > > ERROR 0002: file '/usr/bin/dpdk-test' contains an invalid rpath > 'lib64/dpdk/pmds-20.0' in [lib64/dpdk/pmds-20.0] > > [1] > https://salsa.debian.org/debian/dpdk/-/blob/unstable/debian/rules#L175 > Ok, in that case no problem: Acked-by: Bruce Richarson