From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA266A0519;
	Fri,  3 Jul 2020 10:34:05 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 45B1B1DA4E;
	Fri,  3 Jul 2020 10:34:05 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 1A1931DA4A
 for <dev@dpdk.org>; Fri,  3 Jul 2020 10:34:02 +0200 (CEST)
IronPort-SDR: D5Q03UTsYFsqyR/TrSE/9ow9T6hQaJw/eQUg740IYyefLuD1Gfb4AK1CO5OAsuSBbDqCJRTX5G
 PDsFjXGF7Gng==
X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="145250086"
X-IronPort-AV: E=Sophos;i="5.75,307,1589266800"; d="scan'208";a="145250086"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 03 Jul 2020 01:34:01 -0700
IronPort-SDR: YfXBNOqhG5WaTDf5FH5hkyQam4bbVpgxKtFi5DS2rYL0WEk1TsANH2hND0VE5D2ywHJO+UqIRu
 6NBdUYUu6DOw==
X-IronPort-AV: E=Sophos;i="5.75,307,1589266800"; d="scan'208";a="426230450"
Received: from dhowell-mobl2.ger.corp.intel.com (HELO
 bricha3-MOBL.ger.corp.intel.com) ([10.252.2.251])
 by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 03 Jul 2020 01:34:00 -0700
Date: Fri, 3 Jul 2020 09:33:57 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com
Message-ID: <20200703083357.GA620@bricha3-MOBL.ger.corp.intel.com>
References: <20200618135049.489773-1-bruce.richardson@intel.com>
 <20200622143337.562637-1-bruce.richardson@intel.com>
 <16606461.pgA7MxYrfW@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16606461.pgA7MxYrfW@thomas>
Subject: Re: [dpdk-dev] [PATCH v2 0/4] improve runtime loading of shared
 drivers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 02, 2020 at 11:16:51PM +0200, Thomas Monjalon wrote:
> 22/06/2020 16:33, Bruce Richardson:
> > Bruce Richardson (4):
> >   eal: remove unnecessary null-termination
> 
> Maybe add scope of the change with "in plugin path" ?
> 
> >   eal: only load shared libs from driver plugin directory
> 
> I suggest: "eal: load only shared libraries from plugin directory"
> 
> >   eal: don't load drivers from insecure paths
> 
> I don't know why, I don't like titles starting with "don't".
> I suggest: "eal: forbid plugin from insecure path"
> 
> >   eal: cache last directory permissions checked
> 
Will adjust for v3