From: 197020236@qq.com
To: xavier.huwei@huawei.com
Cc: dev@dpdk.org, pandongyang <197020236@qq.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH V2] net/bonding: delete redundant code
Date: Sat, 4 Jul 2020 09:15:26 +0800 [thread overview]
Message-ID: <20200704011615.E1C0B1DCAC@dpdk.org> (raw)
From: pandongyang <197020236@qq.com>
The function valid_bonded_port_id() has already contains function
rte_eth_dev_is_valid_port(), so delete redundant check.
Fixes: 588ae95e7983 ("net/bonding: fix port ID check")
Cc: stable@dpdk.org
Signed-off-by: pandongyang <197020236@qq.com>
---
v1 -> v2: Adjust commit info
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index b77a37ddb..339374337 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -1675,9 +1675,6 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
dev = &rte_eth_devices[port];
internals = dev->data->dev_private;
- if (check_for_bonded_ethdev(dev) != 0)
- return -1;
-
if (bond_8023ad_slow_pkt_hw_filter_supported(port) != 0)
return -1;
@@ -1704,9 +1701,6 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
dev = &rte_eth_devices[port];
internals = dev->data->dev_private;
- if (check_for_bonded_ethdev(dev) != 0)
- return -1;
-
/* Device must be stopped to set up slow queue */
if (dev->data->dev_started)
return -1;
--
2.23.0.windows.1
next reply other threads:[~2020-07-04 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 1:15 197020236 [this message]
[not found] <20878f97-ff83-4f39-b603-bcd8379fa5a9@DGGEMS414-HUB.china.huawei.com>
2020-07-04 1:22 ` Wei Hu (Xavier)
2020-07-17 11:22 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704011615.E1C0B1DCAC@dpdk.org \
--to=197020236@qq.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).