From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACB63A0524; Sat, 4 Jul 2020 13:48:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8FB01DA82; Sat, 4 Jul 2020 13:48:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 88CA51D9C5 for ; Sat, 4 Jul 2020 13:48:11 +0200 (CEST) IronPort-SDR: rr0BCHkosp365OmGkq5ewmHa+nlFr0TiWrcMREDR8DeliU4cAMUe644ALM94moxK4QurJYMiw+ H/dR03l0Df0A== X-IronPort-AV: E=McAfee;i="6000,8403,9671"; a="134703019" X-IronPort-AV: E=Sophos;i="5.75,311,1589266800"; d="scan'208";a="134703019" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2020 04:48:10 -0700 IronPort-SDR: ZLca0e06VhT5GezKhDSihmy9JSaFtZXI3UdLeaNz/m+b0wcxPtoMxZonVWbG+56ZzRXhAcZYg4 BeHAnwqFN8Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,311,1589266800"; d="scan'208";a="304801195" Received: from silpixa00399126.ir.intel.com ([10.237.222.84]) by fmsmga004.fm.intel.com with ESMTP; 04 Jul 2020 04:48:09 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, Bruce Richardson , Harry van Haaren Date: Sat, 4 Jul 2020 12:48:01 +0100 Message-Id: <20200704114801.1110659-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200617104012.470617-1-bruce.richardson@intel.com> References: <20200617104012.470617-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3] build: check functionality rather than binutils version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than checking the binutils version number, which can lead to unnecessary disabling of AVX512 if fixes have been backported to distro versions, we can instead check the output of "as" from binutils to see if it is correct. The check in the script uses the minimal assembly reproduction code posted to the public bug tracker for gcc/binutils for those issues [1]. If the binutils bug is present, the instruction parameters - specifically the displacement parameter - will be different in the disassembled output compared to the input. Therefore the check involves assembling a single instruction and disassembling it again, checking that the two match. [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 Signed-off-by: Bruce Richardson Tested-by: Harry van Haaren --- V3: - Use mktemp to create a temporary file rather than place object file in build folder. Use trap to ensure temp file deletion on exit. V2: - Renamed "as_ok" variable to "binutils_ok" for readability - Removed one test case from the script because even though two DPDK bugs were filed, the one binutils bug is the root cause, and a single commit fixes them both - Changed message() to warning() in the printout --- buildtools/binutils-avx512-check.sh | 16 ++++++++++++++++ buildtools/meson.build | 3 +-- config/x86/meson.build | 10 +++------- meson.build | 5 ++++- 4 files changed, 24 insertions(+), 10 deletions(-) create mode 100755 buildtools/binutils-avx512-check.sh diff --git a/buildtools/binutils-avx512-check.sh b/buildtools/binutils-avx512-check.sh new file mode 100755 index 000000000..a7e068140 --- /dev/null +++ b/buildtools/binutils-avx512-check.sh @@ -0,0 +1,16 @@ +#! /bin/sh +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2020 Intel Corporation + +AS=${AS:-as} +OBJFILE=$(mktemp -t dpdk.binutils-check.XXXXXX.o) +trap 'rm -f "$OBJFILE"' EXIT +# from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028 +GATHER_PARAMS='0x8(,%ymm1,1),%ymm0{%k2}' + +# assemble vpgather to file and similarly check +echo "vpgatherqq $GATHER_PARAMS" | $AS --64 -o $OBJFILE - +objdump -d --no-show-raw-insn $OBJFILE | grep -q $GATHER_PARAMS || { + echo "vpgatherqq displacement error with as" + exit 1 +} diff --git a/buildtools/meson.build b/buildtools/meson.build index f9d2fdf74..cf0048f3c 100644 --- a/buildtools/meson.build +++ b/buildtools/meson.build @@ -1,13 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017-2019 Intel Corporation -subdir('pmdinfogen') - pkgconf = find_program('pkg-config', 'pkgconf', required: false) pmdinfo = find_program('gen-pmdinfo-cfile.sh') list_dir_globs = find_program('list-dir-globs.py') check_symbols = find_program('check-symbols.sh') ldflags_ibverbs_static = find_program('options-ibverbs-static.sh') +binutils_avx512_check = find_program('binutils-avx512-check.sh') # set up map-to-win script using python, either built-in or external python3 = import('python').find_installation(required: false) diff --git a/config/x86/meson.build b/config/x86/meson.build index adc857ba2..6ec020ef6 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -3,14 +3,10 @@ # get binutils version for the workaround of Bug 97 if not is_windows - ldver = run_command('ld', '-v').stdout().strip() - if ldver.contains('2.30') and cc.has_argument('-mno-avx512f') + binutils_ok = run_command(binutils_avx512_check) + if binutils_ok.returncode() != 0 and cc.has_argument('-mno-avx512f') machine_args += '-mno-avx512f' - message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97') - endif - if ldver.contains('2.31') and cc.has_argument('-mno-avx512f') - machine_args += '-mno-avx512f' - message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249') + warning('Binutils error with AVX512 assembly, disabling AVX512 support') endif endif diff --git a/meson.build b/meson.build index d21adfd30..7c336df6d 100644 --- a/meson.build +++ b/meson.build @@ -40,10 +40,13 @@ global_inc = include_directories('.', 'config', 'lib/librte_eal/@0@/include'.format(host_machine.system()), 'lib/librte_eal/@0@/include'.format(arch_subdir), ) + +# do configuration and get tool paths +subdir('buildtools') subdir('config') # build libs and drivers -subdir('buildtools') +subdir('buildtools/pmdinfogen') subdir('lib') subdir('drivers') -- 2.25.1