From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ABDFA00C5; Mon, 6 Jul 2020 11:57:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D8581DA23; Mon, 6 Jul 2020 11:57:55 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B90A41DA0F; Mon, 6 Jul 2020 11:57:53 +0200 (CEST) IronPort-SDR: Htvg6/cUgXOV7l/dLzxIhHbUkehY1a7nmQSIz+NqRBROPZYkaQ35ks6Y3NSrSX/ClKYaVHNeat lHN0F5uqKHjA== X-IronPort-AV: E=McAfee;i="6000,8403,9673"; a="127457087" X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="127457087" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 02:57:52 -0700 IronPort-SDR: CW6+C0+vDll+jnYl05YGpbNsvZw6BasFlM6f1pIW33ImEUnhT/SoxnFIxisFMgIcFgSO6dyor4 RwCC5+Z0VDNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,318,1589266800"; d="scan'208";a="296951107" Received: from intel.sh.intel.com ([10.239.255.20]) by orsmga002.jf.intel.com with ESMTP; 06 Jul 2020 02:57:50 -0700 From: Shougang Wang To: dev@dpdk.org Cc: Qi Zhang , Yang Qiming , Shougang Wang , stable@dpdk.org Date: Mon, 6 Jul 2020 09:37:05 +0000 Message-Id: <20200706093705.65323-1-shougangx.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When create a rss rule with void action, the error log is "Invalid input set". This patch fix the issue by adding check for the type of first actions item. Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling") Cc: stable@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/ice_generic_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index ad103d0e8..80ef0e323 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -1873,7 +1873,7 @@ ice_flow_process_filter(struct rte_eth_dev *dev, return -rte_errno; } - if (!actions) { + if (!actions || actions->type == RTE_FLOW_ACTION_TYPE_END) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_NUM, NULL, "NULL action."); -- 2.17.1