From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ADF1A00C5; Mon, 6 Jul 2020 13:33:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C2871D97D; Mon, 6 Jul 2020 13:33:02 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 981B81BEE6 for ; Mon, 6 Jul 2020 13:33:00 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from fady@mellanox.com) with SMTP; 6 Jul 2020 14:32:59 +0300 Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 066BWx9L006827; Mon, 6 Jul 2020 14:32:59 +0300 From: Fady Bader To: dev@dpdk.org Cc: thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com, yohadt@mellanox.com, dmitry.kozliuk@gmail.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com Date: Mon, 6 Jul 2020 14:32:39 +0300 Message-Id: <20200706113241.28748-2-fady@mellanox.com> X-Mailer: git-send-email 2.16.1.windows.4 In-Reply-To: <20200706113241.28748-1-fady@mellanox.com> References: <20200705134746.26240-1-fady@mellanox.com> <20200706113241.28748-1-fady@mellanox.com> Subject: [dpdk-dev] [PATCH v7 1/3] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Function versioning implementation is not supported by Windows. Function versioning is disabled on Windows. Signed-off-by: Fady Bader --- doc/guides/windows_gsg/intro.rst | 4 ++++ lib/meson.build | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/windows_gsg/intro.rst b/doc/guides/windows_gsg/intro.rst index a0285732df..58c6246404 100644 --- a/doc/guides/windows_gsg/intro.rst +++ b/doc/guides/windows_gsg/intro.rst @@ -18,3 +18,7 @@ DPDK for Windows is currently a work in progress. Not all DPDK source files compile. Support is being added in pieces so as to limit the overall scope of any individual patch series. The goal is to be able to run any DPDK application natively on Windows. + +The :doc:`../contributing/abi_policy` cannot be respected for Windows. +Minor ABI versions may be incompatible +because function versioning is not supported on Windows. diff --git a/lib/meson.build b/lib/meson.build index c1b9e1633f..dadf151f78 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -107,6 +107,10 @@ foreach l:libraries shared_dep = declare_dependency(include_directories: includes) static_dep = shared_dep else + if is_windows and use_function_versioning + message('@0@: Function versioning is not supported by Windows.' + .format(name)) + endif if use_function_versioning cflags += '-DRTE_USE_FUNCTION_VERSIONING' @@ -138,7 +142,7 @@ foreach l:libraries include_directories: includes, dependencies: static_deps) - if not use_function_versioning + if not use_function_versioning or is_windows # use pre-build objects to build shared lib sources = [] objs += static_lib.extract_all_objects(recursive: false) -- 2.16.1.windows.4