From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2458BA00BE; Tue, 7 Jul 2020 02:43:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FA8D1DCAA; Tue, 7 Jul 2020 02:43:28 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by dpdk.org (Postfix) with ESMTP id AF41E1DC9D for ; Tue, 7 Jul 2020 02:43:26 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id C706E20B717A; Mon, 6 Jul 2020 17:43:25 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C706E20B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1594082605; bh=dbvpbKrujf6lnFBuBBYPFc3+r7ZmCNACKlGZc2EO5HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ShhwYqbIBwvTVm6Hk2TQ4BGu54vz0HVlReXT9+2t9WNSjTL+igV7RNH4SBLA+U1bk p5SBvzftnTi5oNTwYaf2h3WlRAAZetclxh7FOrhPJD1Fqyad1qQAUQQW8nWCepRgHv gjMTNd7MtFDloNsel+kfp72OVuKGx1Nra07QCJ8Q= Date: Mon, 6 Jul 2020 17:43:25 -0700 From: Narcisa Ana Maria Vasile To: talshn@mellanox.com Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com Message-ID: <20200707004325.GA71561@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20200624145621.26604-1-talshn@mellanox.com> <20200624145621.26604-2-talshn@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624145621.26604-2-talshn@mellanox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 24, 2020 at 05:56:20PM +0300, talshn@mellanox.com wrote: > From: Tal Shnaiderman > > Add needed function calls in rte_eal_init to detect vdev PMD. > > eal_option_device_parse() > rte_service_init() > rte_bus_probe() > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/windows/eal.c | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build Implicit declaration warning: ../lib/librte_eal/windows/eal.c:371:6: warning: implicit declaration of function 'rte_service_init' is invalid in C99 [-Wimplicit-function-declaration] if (rte_service_init()) { ^ 1 warning generated. Adding "#include " in windows/eal.c should solve it. Getting some linker error: Creating library drivers\librte_bus_vdev.dll.a and object drivers\librte_bus_vdev.dll.exp bus_vdev_vdev.c.obj : error LNK2019: unresolved external symbol rte_log_register_type_and_pick_level referenced in function __vdev_logtype_bus drivers\librte_bus_vdev-0.200.3.dll : fatal error LNK1120: 1 unresolved externals Probably just a missing export for "rte_log_register_type_and_pick_level" in rte_eal_exports.def? After adding the missing include and export, compilation and linking are successful. I see some errors when running the app though: EAL: error allocating rte services array EAL: FATAL: rte_service_init() failed EAL: rte_service_init() failed PANIC in main(): Cannot init EAL 6: [ (RtlUserThreadStart+0x21)[0x7FFACF283460]] 5: [ (BaseThreadInitThunk+0x14)[0x7FFACE7A6DF0]] 4: [] 3: [] 2: [] 1: []