From: Stephen Hemminger <stephen@networkplumber.org>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org,
stable@dpdk.org, h.mikita89@gmail.com
Subject: Re: [dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset
Date: Tue, 7 Jul 2020 09:09:18 -0700 [thread overview]
Message-ID: <20200707090918.5e909cfe@hermes.lan> (raw)
In-Reply-To: <20200707090320.2463-1-sarosh.arif@emumba.com>
On Tue, 7 Jul 2020 14:03:20 +0500
Sarosh Arif <sarosh.arif@emumba.com> wrote:
> + struct rte_timer_data *timer_data;
> + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);
> +
> + if (tim->status.state == RTE_TIMER_RUNNING && \
> + (tim->status.owner != (uint16_t)tim_lcore || \
> + tim != timer_data->priv_timer[tim_lcore].running_tim))
> + return -1;
> +
This is code not a macro.
Look at checkpatch output, no \ in code.
next prev parent reply other threads:[~2020-07-07 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:03 Sarosh Arif
2020-07-07 16:09 ` Stephen Hemminger [this message]
2020-07-08 5:06 ` [dpdk-dev] [PATCH v2] " Sarosh Arif
2020-07-08 15:07 ` Stephen Hemminger
2020-07-09 7:05 ` Sarosh Arif
2020-07-08 15:08 ` Stephen Hemminger
2020-07-09 7:02 ` Sarosh Arif
2020-07-10 6:59 ` [dpdk-dev] [PATCH v3] " Sarosh Arif
2020-07-10 15:19 ` Stephen Hemminger
2020-07-28 19:04 ` Carrillo, Erik G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707090918.5e909cfe@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=h.mikita89@gmail.com \
--cc=rsanford@akamai.com \
--cc=sarosh.arif@emumba.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).