From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6938AA00BE; Tue, 7 Jul 2020 18:09:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C54DD1D9D5; Tue, 7 Jul 2020 18:09:29 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 20BC61D8F5 for ; Tue, 7 Jul 2020 18:09:28 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id mn17so5171703pjb.4 for ; Tue, 07 Jul 2020 09:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nt4X1dF653jFpBoijQMD9y8wAXCUW7q2v3c/FNPJbJI=; b=ifeXR1Gx8Gm3WyTQ9lMOZlgBNM7V54KA/0GP7bG/p+RiwcRvrpD6P0ybaGiy9gjn79 PFhGxbsUuKrPiFj0eShLonBCk7X4cH8rAn2yuPITkvfRIsgCUbq5DA39Fd5WHXUYOPif yDg7JObgXVq5dj951QlIIcsqgvvGgG5PCFrz8A6IYGtNwIwbhLfokS806dPQZRbKW+oY wZH0FVQrCNbzdihhBqOocw0sWO0nJUQiW1jr6h1rLsaToUPITwCDbO3dAzb0fJZE85aP 6TARmTFu76iC0vOJYopFg+CDY3xJgsZKWHGMpzQPzedk8uo8OFwlnsWH1E3z3aWZUwYC TmYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nt4X1dF653jFpBoijQMD9y8wAXCUW7q2v3c/FNPJbJI=; b=HN0xi1bNxwgUKr9vXbQGPhYyR3RNJfPdwV+Jy2A3kXBHG5ObaOcE1EJu2Y9hMSZti5 Kdfuln+RxGdJCDgM5AOjvDgfCqfyQhvCbF6ht/gialEgI5tnGLA37jqj1c0mhnJo5gs6 1O8blbkEgB7srFBMEJ0apJBAxxwWApXL9sXSu2IRFrVRYctvJYBXEI4WaNr+Qkhv/ppY uICgoQo+O1pEiNl+UJzlplNpZ0TeX5ApuOJxLkEnNk4U6VSSGBLulrzwVbcX5we0r4rs 2x4wyZnuOHAOuZOkC3e1T0NfHLRcpBJsnlEACxXPEd4kRgCgqesxbVOQI5KaRQgpYZnk rezQ== X-Gm-Message-State: AOAM532svlM0w+aQTvaEmHdqnU6zooNXeJKDwxFdff9EedIsVhWeCN4G LnF/cPDdzwSzLbhYdxzCe5W5FQ== X-Google-Smtp-Source: ABdhPJxKuc2L9kvlED7UWp7a8uMMHMtJ3+gwL+c43zAL+gscOW+jZGkHR/PGmPZmjtyinJEepUOoqQ== X-Received: by 2002:a17:90a:d684:: with SMTP id x4mr5048296pju.62.1594138167230; Tue, 07 Jul 2020 09:09:27 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z13sm23007876pfq.220.2020.07.07.09.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 09:09:26 -0700 (PDT) Date: Tue, 7 Jul 2020 09:09:18 -0700 From: Stephen Hemminger To: Sarosh Arif Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org, stable@dpdk.org, h.mikita89@gmail.com Message-ID: <20200707090918.5e909cfe@hermes.lan> In-Reply-To: <20200707090320.2463-1-sarosh.arif@emumba.com> References: <20200707090320.2463-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 7 Jul 2020 14:03:20 +0500 Sarosh Arif wrote: > + struct rte_timer_data *timer_data; > + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL); > + > + if (tim->status.state == RTE_TIMER_RUNNING && \ > + (tim->status.owner != (uint16_t)tim_lcore || \ > + tim != timer_data->priv_timer[tim_lcore].running_tim)) > + return -1; > + This is code not a macro. Look at checkpatch output, no \ in code.