From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16D3FA00BE; Tue, 7 Jul 2020 10:39:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86A2F1DA57; Tue, 7 Jul 2020 10:39:26 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 948781DA40 for <dev@dpdk.org>; Tue, 7 Jul 2020 10:39:24 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id j11so194086ljo.7 for <dev@dpdk.org>; Tue, 07 Jul 2020 01:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QnNVQX5X6Kh9gbpkqreCyHvbmeXimftYW1yBDOLL7IE=; b=UloinxfC/C/IfxdM3tG23htGJcVFzARyzNHMP2LMM6ImyeS4UkvWXTFx/F5i0hMYNh 4ZbaLwspa+6/wq5/TfTFqYNrNoqQZiQBxgJ3CWpVGwjayuQX5ZXOJO21Lj/IPTS615BC LTFIiBanoGJ1nqL2YHtAW8xPUn2M1+8LJa+++B7FKFO3BdVWZ9aG9eGRcDJvtNRmc6x4 Zf1LUVlU/QICKruwZadenfCNGt6WUXzxJrori9mJZ+6YtpfzyYSQe7Lz96XofyzrN8b7 AIX3JwsvpPQi+uMd/QU+WgtTIngVzH4co5GcfIyptt5rWQvQXLGkd5ism1lgoO+hGDf2 Pirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QnNVQX5X6Kh9gbpkqreCyHvbmeXimftYW1yBDOLL7IE=; b=GwXjZZSoIEfL/mAwFUijsX8ZARCTLgJLiZVeTx6HGMueh+FCiIZWDdEg3jScRg4ONS UIuMlUzNUL7VQzevNz8i+F9kPccFSAjFr7BaYWP3YkxcWdTdGujAWXPJged6k3oC1VPp 5L3WplKEWtyflLrvcsTtyhPjkDT7p+F7tMNqzvbWLyNqQkrMnht5e8+6mb1Y4XZYEWCW KsNABIqIQ/QM4OWv8zlW/JOBcKIpop/nrFAUBYNgXfal9ltux3FIhoOAnAGMqXmWwJvQ M8nKyoa3eCiGJQ/CJpofSVaaeyNhbVDUtmk9OUz/y3qZbnDpLSG8e5/U+3T5aTrQ2QSa 0j8A== X-Gm-Message-State: AOAM5320Q43CdHPiMJsJG04T3d+2L4xRVJHNDUBo/XGB4uOSrtxnOUUl wB62Q8rSgoufPDvcKENH0I0= X-Google-Smtp-Source: ABdhPJyBDsHvTMjBvkQjIk70bmW2Gc5rd7rLczTdU4BgmLc5bI41va8kHtfO9TgpHcZCNHJY4SlC2Q== X-Received: by 2002:a2e:854b:: with SMTP id u11mr25817477ljj.99.1594111164044; Tue, 07 Jul 2020 01:39:24 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id c6sm9400415lff.77.2020.07.07.01.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 01:39:23 -0700 (PDT) Date: Tue, 7 Jul 2020 11:39:22 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Tal Shnaiderman <talshn@mellanox.com> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "grive@u256.net" <grive@u256.net>, "ranjit.menon@intel.com" <ranjit.menon@intel.com>, "harini.ramakrishnan@microsoft.com" <harini.ramakrishnan@microsoft.com>, "ocardona@microsoft.com" <ocardona@microsoft.com>, "anatoly.burakov@intel.com" <anatoly.burakov@intel.com> Message-ID: <20200707113922.2e870d2d@sovereign> In-Reply-To: <DB7PR05MB53240C098C917BF7870D72F0A9660@DB7PR05MB5324.eurprd05.prod.outlook.com> References: <20200624145621.26604-1-talshn@mellanox.com> <20200624145621.26604-2-talshn@mellanox.com> <20200707004325.GA71561@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <DB7PR05MB53240C098C917BF7870D72F0A9660@DB7PR05MB5324.eurprd05.prod.outlook.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, 7 Jul 2020 08:04:00 +0000, Tal Shnaiderman wrote: > Dmitry, It looks like we got to this stage since hugepage_claim_privilege() cannot actually detect that "Lock pages" isn't granted to the current user, as a result we fail on the first usage of a memory management call [in this case rte_calloc()] without indication to the reason. > > Is it possible to add an actual check that the current user is in the list of grantees? Thanks, I'll look into it. > Alternatively, It would be great to have this privilege added programmatically, I tried the MSDN example in [2] but it didn't work for me while testing, maybe Microsoft team can check if there is a way to do it? I don't think it's a good idea from security perspective if an application grants its user new privileges implicitly. Process with SeLockMemory privilege can affect overall system performance and stability. -- Dmitry Kozlyuk