From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37219A0527; Wed, 8 Jul 2020 17:08:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08A9E1E4C3; Wed, 8 Jul 2020 17:08:54 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 8305E1E4B2 for ; Wed, 8 Jul 2020 17:08:52 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id e18so21804862pgn.7 for ; Wed, 08 Jul 2020 08:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SJJAGLNke6155Ygi04x7tOmPl2k5DSsZTUSclnWmHwY=; b=bL1MlczM0FH/rPZXswBp6RopaXmiSVZnvyJ4ADR+wymp6Guz2HAG3wLYGpj8DojybE pjMvHB+6C1dv6F9QvQSvrkY9Ad/X55tLMeFC5HYXwFclhampMGEpRX8FMtcQc5+fztGm nLsMCagcWizcJPrC7n0Xsm8AXBm3pC96n4eaeuqWLvWCfmCsmspySlGHuiRspIIvq+I8 SjuJJyQztI6RVpGhvFxKOS2g7fYWPovnINVM+Wb3wdSRl1uO4G9oRrxz+Jk0RJ2ZOZ73 W1YXcTEv3ogy7YQtxJjuawl7pVLh1FNj2zVIsYW2vkyprqcihWK/6GGq60usf82hYCLT jrHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SJJAGLNke6155Ygi04x7tOmPl2k5DSsZTUSclnWmHwY=; b=M8JEd0/IN0XM8GSX5ml447WH4i61p7obYDbwlDGKSePg8r/EAeu/NMnxCzJvFQIN6f MXeoU56v+Yj9jnUODZ9Fgv5mzZOXQd0NM9PxvS2EU674uOVey83nkrfqnGY4YHdqGiNP vjigPg0jMJVyovi25BIEB0FPS1ULc4xx6JFN6ZNtrPCPwD1pp4CRYpkNDno7ycz96L4p /xG7xEE+SbNCKeQuPDjN5ee1+u55aVK2yLfAk3jJLLAqfrfNWwihueQ3CbanoRq51MGu wCTNzy8HzvMnV9kSMYzdxO0UWX9VW5czt5Cjr1U/Xn2MgnFf/4+NU7aNyueG/QZxNFWg 4K8w== X-Gm-Message-State: AOAM533YdqM5IN8Q4UwdzixpiW+grSxIRE9sOu+GBT10yKns0TQAjl2g wKui4mcwuGTSc/CH9bqCUD9uiQ== X-Google-Smtp-Source: ABdhPJzI8A8lTljjctvC2aFCMdsATveTENsPZmTE78yqxl/o1n8i4ARl/vrN9n26TF37+menYLKjxQ== X-Received: by 2002:aa7:8283:: with SMTP id s3mr55045169pfm.90.1594220931632; Wed, 08 Jul 2020 08:08:51 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id az16sm5590pjb.7.2020.07.08.08.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2020 08:08:51 -0700 (PDT) Date: Wed, 8 Jul 2020 08:08:48 -0700 From: Stephen Hemminger To: Sarosh Arif Cc: rsanford@akamai.com, erik.g.carrillo@intel.com, dev@dpdk.org, stable@dpdk.org, h.mikita89@gmail.com Message-ID: <20200708080848.569e8dcd@hermes.lan> In-Reply-To: <20200708050626.23512-1-sarosh.arif@emumba.com> References: <20200707090320.2463-1-sarosh.arif@emumba.com> <20200708050626.23512-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 8 Jul 2020 10:06:26 +0500 Sarosh Arif wrote: > rte_timer_stop_sync(struct rte_timer *tim) > { > + struct rte_timer_data *timer_data; > + TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL); > + unsigned int lcore_id = rte_lcore_id(); This mixing code and declarations. since the macro has a return statement. Maybe: struct rte_timer_data *timer_data; unsigned int lcore_id = rte_lcore_id(); TIMER_DATA_VALID_GET_OR_ERR_RET(default_data_id, timer_data, -EINVAL);