From: Ting Xu <ting.xu@intel.com> To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com, Ting Xu <ting.xu@intel.com>, stable@dpdk.org Subject: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue Date: Thu, 9 Jul 2020 09:48:25 +0800 Message-ID: <20200709014825.13690-1-ting.xu@intel.com> (raw) In-Reply-To: <20200616162705.83575-1-ting.xu@intel.com> When create softnic hash table with 16 keys, it failed on 32bit environment because of the structure rte_bucket_4_16 alignment issue. Add __rte_cache_aligned to ensure correct cache align. Fixes: 8aa327214c ("table: hash") Cc: stable@dpdk.org Signed-off-by: Ting Xu <ting.xu@intel.com> --- v2->v3: Rebase v1->v2: Correct patch time --- lib/librte_table/rte_table_hash_key16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_table/rte_table_hash_key16.c b/lib/librte_table/rte_table_hash_key16.c index 2cca1c924..5e1665c15 100644 --- a/lib/librte_table/rte_table_hash_key16.c +++ b/lib/librte_table/rte_table_hash_key16.c @@ -44,7 +44,7 @@ struct rte_bucket_4_16 { uint64_t key[4][2]; /* Cache line 2 */ - uint8_t data[0]; + uint8_t data[0] __rte_cache_aligned; }; struct rte_table_hash { -- 2.17.1
next prev parent reply other threads:[~2020-07-09 1:44 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-16 16:27 [dpdk-dev] [PATCH v1] " Ting Xu 2020-06-17 5:43 ` [dpdk-dev] [PATCH v2] " Ting Xu 2020-07-02 8:06 ` Zhou, JunX W 2020-07-09 1:48 ` Ting Xu [this message] 2020-07-20 14:37 ` [dpdk-dev] [PATCH v3] " Dumitrescu, Cristian 2020-07-21 5:15 ` Xu, Ting 2020-07-21 21:16 ` Dumitrescu, Cristian 2020-07-22 2:16 ` Xu, Ting 2020-07-22 2:16 ` [dpdk-dev] [PATCH v4] " Ting Xu 2020-07-22 8:26 ` Dumitrescu, Cristian 2020-07-22 8:30 ` Xu, Ting 2020-07-22 8:49 ` Dumitrescu, Cristian 2020-07-22 8:48 ` Dumitrescu, Cristian 2020-07-29 12:01 ` David Marchand 2020-07-29 13:13 ` Dumitrescu, Cristian 2020-07-29 13:28 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-07-29 13:54 ` Dumitrescu, Cristian 2020-07-29 13:59 ` David Marchand 2020-07-29 14:53 ` Dumitrescu, Cristian 2020-07-30 6:57 ` Xu, Ting 2020-07-30 10:35 ` Kevin Traynor 2020-09-09 6:18 ` Xu, Ting 2020-09-15 8:03 ` David Marchand 2020-10-14 8:26 ` Xu, Ting 2020-10-14 13:53 ` [dpdk-dev] " David Marchand 2020-07-09 1:44 [dpdk-dev] [PATCH v3] " Ting Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200709014825.13690-1-ting.xu@intel.com \ --to=ting.xu@intel.com \ --cc=cristian.dumitrescu@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git