From: Olivier Matz <olivier.matz@6wind.com> To: Konstantin Ananyev <konstantin.ananyev@intel.com> Cc: dev@dpdk.org, arybchenko@solarflare.com, jielong.zjl@antfin.com, gage.eads@intel.com Subject: Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes Date: Thu, 9 Jul 2020 18:18:29 +0200 Message-ID: <20200709161829.GV5869@platinum> (raw) In-Reply-To: <20200629161024.29059-1-konstantin.ananyev@intel.com> Hi Konstantin, On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > v2: > - update Release Notes (as per comments) > > Two new sync modes were introduced into rte_ring: > relaxed tail sync (RTS) and head/tail sync (HTS). > This change provides user with ability to select these > modes for ring based mempool via mempool ops API. > > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > Acked-by: Gage Eads <gage.eads@intel.com> > --- > doc/guides/rel_notes/release_20_08.rst | 6 ++ > drivers/mempool/ring/rte_mempool_ring.c | 97 ++++++++++++++++++++++--- > 2 files changed, 94 insertions(+), 9 deletions(-) > > diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst > index eaaf11c37..7bdcf3aac 100644 > --- a/doc/guides/rel_notes/release_20_08.rst > +++ b/doc/guides/rel_notes/release_20_08.rst > @@ -84,6 +84,12 @@ New Features > * Dump ``rte_flow`` memory consumption. > * Measure packet per second forwarding. > > +* **Added support for new sync modes into mempool ring driver.** > + > + Added ability to select new ring synchronisation modes: > + ``relaxed tail sync (ring_mt_rts)`` and ``head/tail sync (ring_mt_hts)`` > + via mempool ops API. > + > > Removed Items > ------------- > diff --git a/drivers/mempool/ring/rte_mempool_ring.c b/drivers/mempool/ring/rte_mempool_ring.c > index bc123fc52..15ec7dee7 100644 > --- a/drivers/mempool/ring/rte_mempool_ring.c > +++ b/drivers/mempool/ring/rte_mempool_ring.c > @@ -25,6 +25,22 @@ common_ring_sp_enqueue(struct rte_mempool *mp, void * const *obj_table, > obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > } > > +static int > +rts_ring_mp_enqueue(struct rte_mempool *mp, void * const *obj_table, > + unsigned int n) > +{ > + return rte_ring_mp_rts_enqueue_bulk(mp->pool_data, > + obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > +} > + > +static int > +hts_ring_mp_enqueue(struct rte_mempool *mp, void * const *obj_table, > + unsigned int n) > +{ > + return rte_ring_mp_hts_enqueue_bulk(mp->pool_data, > + obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > +} > + > static int > common_ring_mc_dequeue(struct rte_mempool *mp, void **obj_table, unsigned n) > { > @@ -39,17 +55,30 @@ common_ring_sc_dequeue(struct rte_mempool *mp, void **obj_table, unsigned n) > obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > } > > +static int > +rts_ring_mc_dequeue(struct rte_mempool *mp, void **obj_table, unsigned int n) > +{ > + return rte_ring_mc_rts_dequeue_bulk(mp->pool_data, > + obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > +} > + > +static int > +hts_ring_mc_dequeue(struct rte_mempool *mp, void **obj_table, unsigned int n) > +{ > + return rte_ring_mc_hts_dequeue_bulk(mp->pool_data, > + obj_table, n, NULL) == 0 ? -ENOBUFS : 0; > +} > + > static unsigned > common_ring_get_count(const struct rte_mempool *mp) > { > return rte_ring_count(mp->pool_data); > } > > - > static int > -common_ring_alloc(struct rte_mempool *mp) > +ring_alloc(struct rte_mempool *mp, uint32_t rg_flags) > { > - int rg_flags = 0, ret; > + int ret; > char rg_name[RTE_RING_NAMESIZE]; > struct rte_ring *r; > > @@ -60,12 +89,6 @@ common_ring_alloc(struct rte_mempool *mp) > return -rte_errno; > } > > - /* ring flags */ > - if (mp->flags & MEMPOOL_F_SP_PUT) > - rg_flags |= RING_F_SP_ENQ; > - if (mp->flags & MEMPOOL_F_SC_GET) > - rg_flags |= RING_F_SC_DEQ; > - > /* > * Allocate the ring that will be used to store objects. > * Ring functions will return appropriate errors if we are > @@ -82,6 +105,40 @@ common_ring_alloc(struct rte_mempool *mp) > return 0; > } > > +static int > +common_ring_alloc(struct rte_mempool *mp) > +{ > + uint32_t rg_flags; > + > + rg_flags = 0; Maybe it could go on the same line > + > + /* ring flags */ Not sure we need to keep this comment > + if (mp->flags & MEMPOOL_F_SP_PUT) > + rg_flags |= RING_F_SP_ENQ; > + if (mp->flags & MEMPOOL_F_SC_GET) > + rg_flags |= RING_F_SC_DEQ; > + > + return ring_alloc(mp, rg_flags); > +} > + > +static int > +rts_ring_alloc(struct rte_mempool *mp) > +{ > + if ((mp->flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET)) != 0) > + return -EINVAL; Why do we need this? It is a problem to allow sc/sp in this mode (even if it's not optimal)? > + > + return ring_alloc(mp, RING_F_MP_RTS_ENQ | RING_F_MC_RTS_DEQ); > +} > + > +static int > +hts_ring_alloc(struct rte_mempool *mp) > +{ > + if ((mp->flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET)) != 0) > + return -EINVAL; > + > + return ring_alloc(mp, RING_F_MP_HTS_ENQ | RING_F_MC_HTS_DEQ); > +} > + > static void > common_ring_free(struct rte_mempool *mp) > { > @@ -130,7 +187,29 @@ static const struct rte_mempool_ops ops_sp_mc = { > .get_count = common_ring_get_count, > }; > > +/* ops for mempool with ring in MT_RTS sync mode */ > +static const struct rte_mempool_ops ops_mt_rts = { > + .name = "ring_mt_rts", > + .alloc = rts_ring_alloc, > + .free = common_ring_free, > + .enqueue = rts_ring_mp_enqueue, > + .dequeue = rts_ring_mc_dequeue, > + .get_count = common_ring_get_count, > +}; > + > +/* ops for mempool with ring in MT_HTS sync mode */ > +static const struct rte_mempool_ops ops_mt_hts = { > + .name = "ring_mt_hts", > + .alloc = hts_ring_alloc, > + .free = common_ring_free, > + .enqueue = hts_ring_mp_enqueue, > + .dequeue = hts_ring_mc_dequeue, > + .get_count = common_ring_get_count, > +}; > + > MEMPOOL_REGISTER_OPS(ops_mp_mc); > MEMPOOL_REGISTER_OPS(ops_sp_sc); > MEMPOOL_REGISTER_OPS(ops_mp_sc); > MEMPOOL_REGISTER_OPS(ops_sp_mc); > +MEMPOOL_REGISTER_OPS(ops_mt_rts); > +MEMPOOL_REGISTER_OPS(ops_mt_hts); Not really related to your patch, but I think we need a function to dump the name of available mempool ops. We could even add a description. The problem we have is that a user does not know on which criteria is should use a driver or another (except for platform drivers). Olivier
next prev parent reply other threads:[~2020-07-09 16:18 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-21 13:20 [dpdk-dev] [PATCH 20.08] " Konstantin Ananyev 2020-06-29 16:10 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev 2020-07-09 16:18 ` Olivier Matz [this message] 2020-07-09 17:55 ` Ananyev, Konstantin 2020-07-10 12:52 ` Olivier Matz 2020-07-10 15:15 ` Ananyev, Konstantin 2020-07-10 15:20 ` Ananyev, Konstantin 2020-07-13 13:30 ` Olivier Matz 2020-07-13 14:46 ` Ananyev, Konstantin 2020-07-13 15:00 ` Olivier Matz 2020-07-13 16:29 ` Ananyev, Konstantin 2020-07-10 16:21 ` [dpdk-dev] [PATCH v3] " Konstantin Ananyev 2020-07-10 22:44 ` Thomas Monjalon 2020-07-13 12:58 ` Ananyev, Konstantin 2020-07-13 13:57 ` Thomas Monjalon 2020-07-13 15:50 ` [dpdk-dev] [PATCH v4 0/2] " Konstantin Ananyev 2020-07-13 15:50 ` [dpdk-dev] [PATCH v4 1/2] doc: add ring based mempool guide Konstantin Ananyev 2020-07-13 15:50 ` [dpdk-dev] [PATCH v4 2/2] mempool/ring: add support for new ring sync modes Konstantin Ananyev 2020-07-13 17:37 ` Thomas Monjalon 2020-07-14 9:16 ` Ananyev, Konstantin 2020-07-15 9:59 ` Thomas Monjalon 2020-07-15 14:58 ` [dpdk-dev] [PATCH v5 0/2] " Konstantin Ananyev 2020-07-15 14:58 ` [dpdk-dev] [PATCH v5 1/2] doc: add ring based mempool guide Konstantin Ananyev 2020-07-15 14:58 ` [dpdk-dev] [PATCH v5 2/2] mempool/ring: add support for new ring sync modes Konstantin Ananyev 2020-07-21 17:25 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200709161829.GV5869@platinum \ --to=olivier.matz@6wind.com \ --cc=arybchenko@solarflare.com \ --cc=dev@dpdk.org \ --cc=gage.eads@intel.com \ --cc=jielong.zjl@antfin.com \ --cc=konstantin.ananyev@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git