From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45394A0540; Mon, 13 Jul 2020 15:28:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEF5D1D72A; Mon, 13 Jul 2020 15:28:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 19A3E1D71C for ; Mon, 13 Jul 2020 15:28:26 +0200 (CEST) IronPort-SDR: v0DoHwB1AdU6U8fZDdxsxrD3887JoycI851B0WbYfDVT23fuZBkpCoufZB0SNMUMN0LGbIThD8 ssqSzmY0MAjg== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="128185424" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="128185424" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 06:28:26 -0700 IronPort-SDR: 6zlQoX2lDGSAwhbWJkiuVhbadtoHk8p4ElQOibRaGiYcJ28reJwdZIOE/GyqcyVaQbwjFQ0xlk ilAKDkNF49pQ== X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459293555" Received: from bricha3-mobl.ger.corp.intel.com ([10.249.32.149]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Jul 2020 06:28:24 -0700 Date: Mon, 13 Jul 2020 14:28:20 +0100 From: Bruce Richardson To: Cheng Jiang Cc: dev@dpdk.org, patrick.fu@intel.com Message-ID: <20200713132820.GI694@bricha3-MOBL.ger.corp.intel.com> References: <20200713071519.110662-1-Cheng1.jiang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713071519.110662-1-Cheng1.jiang@intel.com> Subject: Re: [dpdk-dev] [PATCH 20.11] raw/ioat: added a flag to control copying handle parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 13, 2020 at 07:15:19AM +0000, Cheng Jiang wrote: > Added a flag which controls whether rte_ioat_enqueue_copy > and rte_ioat_completed_copies function should process > handle parameters to improve the performance when handle > parameters are not necessary to use. This is targeting > 20.11 release. > > Signed-off-by: Cheng Jiang > --- > drivers/raw/ioat/ioat_rawdev.c | 1 + > drivers/raw/ioat/rte_ioat_rawdev.h | 14 +++++++++++--- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c > index 87fd088aa..5bf030785 100644 > --- a/drivers/raw/ioat/ioat_rawdev.c > +++ b/drivers/raw/ioat/ioat_rawdev.c > @@ -57,6 +57,7 @@ ioat_dev_configure(const struct rte_rawdev *dev, rte_rawdev_obj_t config) > return -EINVAL; > > ioat->ring_size = params->ring_size; > + ioat->hdls_enable = params->hdls_enable; > if (ioat->desc_ring != NULL) { > rte_memzone_free(ioat->desc_mz); > ioat->desc_ring = NULL; > diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h > index f765a6557..daca04dd3 100644 > --- a/drivers/raw/ioat/rte_ioat_rawdev.h > +++ b/drivers/raw/ioat/rte_ioat_rawdev.h > @@ -35,6 +35,7 @@ > */ > struct rte_ioat_rawdev_config { > unsigned short ring_size; > + bool hdls_enable; > }; > You need a doxygen comment on the new structure member (and add to existing one). While it's fairly clear what ring_size parameter should do, the hdls_enable one needs a proper explanation. I also think you might want to investigate changing it to "hdls_disable" so that the default zero-value is the current behaviour. Requiring it to be set as 1 means that existing code will likely recompile but fail to work. For example, the ioat_rawdev_autotest fails on completion checks now.