From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57606A0540; Tue, 14 Jul 2020 08:05:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BCC61D551; Tue, 14 Jul 2020 08:05:52 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 9971D1D530 for ; Tue, 14 Jul 2020 08:05:50 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id a24so1509482pfc.10 for ; Mon, 13 Jul 2020 23:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=IzhdYYB7AoKiTCEx1hmhLxeM6Rwst9IoHQ0+6BKDQtU=; b=TdRoQ2jV0YYDz/6jMdPzQX6LSEJzof2lmJp0PmCXlRgdCQ0ELEVlaW/UaxpSvoLBuo RvAuv4PDpslhRtmOrI36d60lBe0mVWISEeDW8G2tXWrM/2s9O8VtFaTlAKaItCUQiMfU VAxsqtF2p/vtg/C+zYxnJ8+haYWcQioyBQNnNiVdBOAJ63aHxNAtLxqJRU/AeberZgdO 8YXJyRPieyQCCKsGLeJC0eS87e/OQfrCkqNn8GruZq142iu/mqMAdB/F1o4zE6bOX5uj Cw/nRoGnAzB6za1osgcQ6qDRAQK9pnbusdlpZDwIxi/LtdQg4ZpPXOhyhHOa1yi/7gvA grYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IzhdYYB7AoKiTCEx1hmhLxeM6Rwst9IoHQ0+6BKDQtU=; b=b+Zq1fVOnsE+S3kto/wOHQ9xU+oXHL2QshdSzsmS5IgVfbMP/6bClycE4dSzxrSjod 2uJ9vNZLmwykSkUiLhXfZmAGz433n4/jmEGa8u3F2DYZPP/aHiBKleDtSofThHMH5fcc 0uFWMzz90UUH3bvMUex0jc8y1PmD8AZuR2Q7BY81XXvOVBJYThm/eYv9MWNxv2UW5Yn7 O2hbhev/MPw/6W33wOikF0Gykj3x1wW7RJqVFDhioaFnkcp1kTRxdGoodKB9ISZhun5+ PN0KCQDjsHlJUnwWqnfWb/l5o1sWD/rRdWce07OFZ94tXDFCzQDWgeWo9F2wHBvoo6sH pZ5Q== X-Gm-Message-State: AOAM530YqH1fAaPep6wu7ohDNefKUEKNw2W3iKpXZg1P56cPRG9LzPQx a6+TE4i5ZjdQFfaa4G+ryQmWIlZvE40Gkg== X-Google-Smtp-Source: ABdhPJwTAa2o7ONzI8GAPoYzienxmRRirCayTLKz4eBSchoriitmUILdmCKZ4mRkXNtWHyFneWq5nQ== X-Received: by 2002:aa7:9542:: with SMTP id w2mr2761490pfq.273.1594706749138; Mon, 13 Jul 2020 23:05:49 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 193sm15743596pfz.85.2020.07.13.23.05.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 23:05:48 -0700 (PDT) Date: Mon, 13 Jul 2020 23:05:41 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20200713230541.770cdabe@hermes.lan> In-Reply-To: <20200714053919.5609-1-stephen@networkplumber.org> References: <20200613000055.7909-1-stephen@networkplumber.org> <20200714053919.5609-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 00/11] rename blacklist/whitelist to exclude/include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 13 Jul 2020 22:39:08 -0700 Stephen Hemminger wrote: > The terms blacklist and whitelist are often seen as reminders > of the divisions in society. Instead, use more exact terms for > handling of which devices are used in DPDK. > > This is a proposed change for DPDK 20.08 to replace the names > blacklist and whitelist in API and command lines. > > The first three patches fix some other unnecessary use of > blacklist/whitelist and have no user visible impact. > > The rest change the PCI blacklist to be blocklist and > whitelist to be allowlist. > > Thank you for the support and review of this patch. > > v4 - change to use pci-include/pci-exclude for options > incorporate review feedback > keep old options (with approporiate deprecation notice) > update examples in doc > > Stephen Hemminger (11): > rte_ethdev: change comment to rte_dev_eth_mac_addr_add > mk: replace reference to blacklist/whitelist > check_maintainers: change variable names > eal: replace usage of blacklist/whitelist in enum > drivers: replace references to blacklist > eal: replace pci-whitelist/pci-blacklist options > doc: replace references to blacklist/whitelist > app/test: use new allowlist and blocklist > doc: add note about blacklist/whitelist changes > eal: mark old macros for blacklist/whitelist as deprecated > doc: update examples to new config options > > app/test/autotest.py | 16 ++--- > app/test/autotest_runner.py | 18 +++--- > app/test/test.c | 2 +- > app/test/test_eal_flags.c | 52 ++++++++-------- > devtools/check-maintainers.sh | 8 +-- > doc/guides/cryptodevs/dpaa2_sec.rst | 4 +- > doc/guides/cryptodevs/dpaa_sec.rst | 4 +- > doc/guides/cryptodevs/qat.rst | 6 +- > doc/guides/eventdevs/octeontx2.rst | 20 +++---- > doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- > doc/guides/linux_gsg/build_sample_apps.rst | 2 +- > doc/guides/linux_gsg/eal_args.include.rst | 14 ++--- > doc/guides/linux_gsg/linux_drivers.rst | 4 +- > doc/guides/mempool/octeontx2.rst | 4 +- > doc/guides/nics/bnxt.rst | 6 +- > doc/guides/nics/cxgbe.rst | 12 ++-- > doc/guides/nics/dpaa.rst | 4 +- > doc/guides/nics/dpaa2.rst | 4 +- > doc/guides/nics/enic.rst | 12 ++-- > doc/guides/nics/fail_safe.rst | 18 +++--- > doc/guides/nics/features.rst | 2 +- > doc/guides/nics/i40e.rst | 12 ++-- > doc/guides/nics/ice.rst | 18 +++--- > doc/guides/nics/mlx4.rst | 16 ++--- > doc/guides/nics/mlx5.rst | 12 ++-- > doc/guides/nics/octeontx2.rst | 22 +++---- > doc/guides/nics/sfc_efx.rst | 2 +- > doc/guides/nics/tap.rst | 10 ++-- > doc/guides/nics/thunderx.rst | 4 +- > .../prog_guide/env_abstraction_layer.rst | 7 +-- > doc/guides/prog_guide/multi_proc_support.rst | 4 +- > doc/guides/rel_notes/known_issues.rst | 4 +- > doc/guides/rel_notes/release_20_08.rst | 6 ++ > doc/guides/rel_notes/release_2_1.rst | 2 +- > doc/guides/sample_app_ug/bbdev_app.rst | 6 +- > doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- > doc/guides/sample_app_ug/l3_forward.rst | 2 +- > .../sample_app_ug/l3_forward_access_ctrl.rst | 2 +- > .../sample_app_ug/l3_forward_power_man.rst | 2 +- > doc/guides/sample_app_ug/vdpa.rst | 2 +- > doc/guides/tools/cryptoperf.rst | 6 +- > doc/guides/tools/flow-perf.rst | 2 +- > drivers/bus/dpaa/dpaa_bus.c | 7 +-- > drivers/bus/fslmc/fslmc_bus.c | 9 ++- > drivers/bus/fslmc/fslmc_vfio.c | 8 +-- > drivers/bus/pci/pci_common.c | 24 ++++---- > drivers/bus/vmbus/vmbus_common.c | 4 +- > drivers/crypto/virtio/virtio_pci.c | 2 +- > drivers/net/fm10k/fm10k_ethdev.c | 2 +- > drivers/net/virtio/virtio_pci.c | 2 +- > lib/librte_eal/common/eal_common_devargs.c | 14 ++--- > lib/librte_eal/common/eal_common_options.c | 59 ++++++++++++------- > lib/librte_eal/common/eal_options.h | 8 ++- > lib/librte_eal/include/rte_bus.h | 13 +++- > lib/librte_eal/include/rte_dev.h | 12 +++- > lib/librte_eal/include/rte_devargs.h | 12 +++- > lib/librte_ethdev/rte_ethdev.h | 3 +- > mk/rte.sdktest.mk | 14 ++--- > 58 files changed, 299 insertions(+), 255 deletions(-) > There are some bogus checkpatch complaints against patches in this series. The new linux kernel checkpatch now complains about whitelist/blacklist so any attempt to fix would hit that. Also, Linux kernel checkpatch now wants the magic fallthrough; which in Linux kernel is a macro but does not exist in DPDK. Someone want to fix checkpatch for that one?