From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: thomas@monjalon.net, mdr@ashroe.eu, nhorman@tuxdriver.com, dodji@redhat.com, aconole@redhat.com Subject: [dpdk-dev] [PATCH v2] devtools: give some hints for ABI errors Date: Wed, 15 Jul 2020 14:15:05 +0200 Message-ID: <20200715121505.3949-1-david.marchand@redhat.com> (raw) In-Reply-To: <20200708102212.3311-1-david.marchand@redhat.com> abidiff can provide some more information about the ABI difference it detected. In all cases, a discussion on the mailing must happen but we can give some hints to know if this is a problem with the script calling abidiff, a potential ABI breakage or an unambiguous ABI breakage. Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Ray Kinsella <mdr@ashroe.eu> Acked-by: Neil Horman <nhorman@tuxdriver.com> --- Changes since v1: - used arithmetic test, - updated error message for generic errors, --- devtools/check-abi.sh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index e17fedbd9f..172e934382 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do error=1 continue fi - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { + abiret=$? echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" error=1 - fi + echo + if [ $(($abiret & 3)) -ne 0 ]; then + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, this could be a script or environment issue." + fi + if [ $(($abiret & 4)) -ne 0 ]; then + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." + fi + if [ $(($abiret & 8)) -ne 0 ]; then + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." + fi + echo + } done [ -z "$error" ] || [ -n "$warnonly" ] -- 2.23.0
next prev parent reply other threads:[~2020-07-15 12:15 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 10:22 [dpdk-dev] [PATCH] " David Marchand 2020-07-08 13:09 ` Kinsella, Ray 2020-07-08 13:15 ` David Marchand 2020-07-08 13:22 ` Kinsella, Ray 2020-07-08 13:45 ` Aaron Conole 2020-07-08 14:01 ` Kinsella, Ray 2020-07-09 15:52 ` Dodji Seketeli 2020-07-10 7:37 ` Kinsella, Ray 2020-07-10 10:58 ` Neil Horman 2020-07-15 12:15 ` David Marchand [this message] 2020-07-15 12:48 ` [dpdk-dev] [PATCH v2] " Aaron Conole 2020-07-16 7:29 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200715121505.3949-1-david.marchand@redhat.com \ --to=david.marchand@redhat.com \ --cc=aconole@redhat.com \ --cc=dev@dpdk.org \ --cc=dodji@redhat.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git