From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF377A0545; Wed, 15 Jul 2020 14:15:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F4011BED0; Wed, 15 Jul 2020 14:15:35 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 79E301BEBF for ; Wed, 15 Jul 2020 14:15:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594815332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w6RojTBVrPOezOn288qd2GrCTW3Vr84JO9CG6OkhTRU=; b=iCKVFepSjZlsPpXqga1xe690yQh0OBcABq3sJzT2UQTaE9I6nZOrZ2WVU+yICLEOy7/q1E ZRYcgF2v5kGMzoTTLZEMfHoAL8B/vFp1A4XSSEPtBm+GxMi33FjDKLx1rXmUKo5W+DqvGf rFDYSC1uW6GdRJXCA4LoEeXPyNZSkII= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-FK5NGVi5NI-XK81kFkgZww-1; Wed, 15 Jul 2020 08:15:29 -0400 X-MC-Unique: FK5NGVi5NI-XK81kFkgZww-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBC7A100A8EC; Wed, 15 Jul 2020 12:15:27 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.195.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBE6A10013C2; Wed, 15 Jul 2020 12:15:21 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, mdr@ashroe.eu, nhorman@tuxdriver.com, dodji@redhat.com, aconole@redhat.com Date: Wed, 15 Jul 2020 14:15:05 +0200 Message-Id: <20200715121505.3949-1-david.marchand@redhat.com> In-Reply-To: <20200708102212.3311-1-david.marchand@redhat.com> References: <20200708102212.3311-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] devtools: give some hints for ABI errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" abidiff can provide some more information about the ABI difference it detected. In all cases, a discussion on the mailing must happen but we can give some hints to know if this is a problem with the script calling abidiff, a potential ABI breakage or an unambiguous ABI breakage. Signed-off-by: David Marchand Acked-by: Ray Kinsella Acked-by: Neil Horman --- Changes since v1: - used arithmetic test, - updated error message for generic errors, --- devtools/check-abi.sh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index e17fedbd9f..172e934382 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do error=1 continue fi - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { + abiret=$? echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" error=1 - fi + echo + if [ $(($abiret & 3)) -ne 0 ]; then + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, this could be a script or environment issue." + fi + if [ $(($abiret & 4)) -ne 0 ]; then + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." + fi + if [ $(($abiret & 8)) -ne 0 ]; then + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." + fi + echo + } done [ -z "$error" ] || [ -n "$warnonly" ] -- 2.23.0