From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5D1BA0546; Thu, 16 Jul 2020 09:30:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FDEF1BEDE; Thu, 16 Jul 2020 09:30:09 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60085.outbound.protection.outlook.com [40.107.6.85]) by dpdk.org (Postfix) with ESMTP id 333F51BED5 for ; Thu, 16 Jul 2020 09:30:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItFBFVW9od9e25RYN0LfWwinwAbbXZ384NJHtLaD2VWoYz65HlUlKLmv0tTCgRsD5ggzU6vkfjnJFGyY33h7IsS+phgFpWBhIrdREpy72pt1YcYdIvBIPD4LXcSwbcK2mDk0bWJ7RytVzu/E7Xa+03wqVy1wlZsC2QpY7VOTOvIFLlUae8EswuwYlL/vdN1RIzvDsWarC9zd68AwXxSfMSMGTkTc96jDspf6EqcxcI0SJvauaxYgsFPiY0MKzjyZYF8uidDmyJENX4KgiamUJRwRfNdAoHGHRtsqbAOIx+3+eBislN94ZQrd3f9rV9W5J6Gl0iIIuI4Bm0uX/dLDXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=GugWFk4RZY7bKtBxEoH6F93uYr7oakef5SFZTtSwvMETDzbW34B4Pb2SaGp6eQaZcC4ktYD+pqwGi7RmNcb0QeIY6Z0G9VHf0NP2FFujTtp73PsvVpR+qwSt4DaFJUkm4vn+2gC46NyTbzBebNU9BReJdZWnJW0CF9cIUjcWPoUp0CNAPPQoADsFie8CRy537Od+MeFVAIr0g5IyDyBH4jWMJATT0z1s2JTUWpVZHshWcK+xcpuUgtzT+LtoIIW0PrlSz5SB8shctThhfJBQkZqwGlg9vkh+aIE3tdRCIDVedhVLCvMwxF24P+UUlBCbEm9wiQ6ealBs97lC/bzNMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RpWOBd3pblhqrkJ0OEo5WAC0kGA/NL4QMCyIMNN5gO8=; b=B/UPbX+kGkMYfssFBBa6INqz4kKrd0EFoOcc/FhZX2pk5tJqMT/g2RulJ0De+7g9DiTbaMHMXKV5hbvLgziLpPnPzgbq+2MuShgd/wDRWV8jW5MLF50y5/fUXF0ZrMsH+SSf4m0kyEgOrvDy8CLwHot0hWpYHrq8yiyY3X9aaTg= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB5329.eurprd05.prod.outlook.com (2603:10a6:208:ed::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Thu, 16 Jul 2020 07:30:05 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 07:30:05 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Thu, 16 Jul 2020 10:29:32 +0300 Message-Id: <20200716072938.812733-4-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200716072938.812733-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200716072938.812733-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SN6PR16CA0057.namprd16.prod.outlook.com (2603:10b6:805:ca::34) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by SN6PR16CA0057.namprd16.prod.outlook.com (2603:10b6:805:ca::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Thu, 16 Jul 2020 07:30:03 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 53dd117d-2f1a-4bd0-b084-08d8295a0f04 X-MS-TrafficTypeDiagnostic: AM0PR05MB5329: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FpEzMWpQzR6nYSlo17iTXqreTNAeR7KM89wAGiW3jwAwIwmwXO/nbpjA5Z2E/WPGp9wnPdeR/rezoJTwK+HbDqHGZCVj0bmqkn2Pf/b8p3ZsRgC5vI8k5VUkTXP+fTf2jKABtpl2U8Oafq758ZIDue0z7arltf2Bbm5p9KbECDaf1NtlRbyp1Al3x4kb5+IqSnhXtal8xaAzd1tZmlw5IKTyMmCyWX1phK3MGrluOdLET6wOhYbt7miNKLf+dtj4rCSFSLd8G31QYeSRM5PmZbmVB09GvnzMJ4Y2oKrPFzgopTKN0YvQLzYRoQ52oxrf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(136003)(396003)(39860400002)(6506007)(6666004)(16526019)(186003)(66946007)(107886003)(66556008)(26005)(8936002)(86362001)(6512007)(6486002)(52116002)(83380400001)(66476007)(5660300002)(2616005)(956004)(36756003)(8676002)(478600001)(316002)(1076003)(2906002)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Tnu33LkYMiYNjDaz9ajHPY2CMYjkbcsYBCy0SL12qzzlXpLkhi7C7bVuWlcrCwJFaErpaNWZFvLO/UYelaSok6Qc5UHDOGn+8az/qivUu5GFL0ws+of02M9DcZlW9oi/a9n3gt946kxpYhVH/G0HMM8UQcV1U/7P/6kioBUYQU7jMBIXFZALksS40q/ROZpFn4RUIpITegr/8fnXKDP5/up94KGeR/pF/tZV/8zKIYwvh0jXPskusdFrmovjZEllvutQ2yB+b8yC3gJUf39aE93oH2/Okdfd1BFOhFKBXZwyBL+7BHTEZtoEHmLCHgtl2RnnQHPjFmOy/W6TpC5bA5spMrFI0t0a5N6HPUb53mv2um6JFq1CWGbO3Owy6+oq1XCKDpqBQc89u4x6DPOTK/Phtv3IfIRlHmM4opCiud4ZEdgbuAMKSUX6na7jCkk/NayKGCDkoYi9mzbqtX5OzP+U3baoje2dtxYVntGpqfA7j9trcBjPbeEBzPPKfqEg X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53dd117d-2f1a-4bd0-b084-08d8295a0f04 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 07:30:05.0315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0ddtp08FgRwhUnJtmGR29tIaYY3idCe6nIdGSNulkB+BCqCfIhjauWrSggR3LezfKoEoBvgqE7v1fibwn7X06w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5329 Subject: [dpdk-dev] [PATCH v6 3/9] common/mlx5: fix empty input style in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index 069d8540c..e5e052a6a 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2