From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 86328A0527;
	Fri, 17 Jul 2020 00:04:41 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5C47A2C58;
	Fri, 17 Jul 2020 00:04:40 +0200 (CEST)
Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com
 [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id A7D8B2C57
 for <dev@dpdk.org>; Fri, 17 Jul 2020 00:04:38 +0200 (CEST)
Received: by mail-pf1-f193.google.com with SMTP id t11so4318545pfq.11
 for <dev@dpdk.org>; Thu, 16 Jul 2020 15:04:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=2qKG002AHQ5ixqmdlB2lr0Q9l9uQbSQWgSEXoxGPsYg=;
 b=Galr0UxYaAFarBso92YgQJsOl+/gHn0ImxU86oYZEjEDDSlo344T0RK1HgYQo7OnOO
 PbgqPb6izwDylvaSwHRjCkh7ZZzsMLrFuRqM+gwhIgFHjFD0EIiyXAhOTwr16npaUz+c
 dm8GPn9zGYUqbhTjMqQWuuwOHwTAjeJQb9bfZKkOja//I9gXvxN1HlO4vw5/t2VFYKUB
 fP3p7eo+kzOvSAa6FAwgyF1QKcLaUcAIdYqu9VH6DBui4nWezBB8B+Jxh5QMaslTly9y
 hENDXC2hm2god4lCErHiec/PU9+GJ7iqcHmcyrDDvB+It0FJSxA+LtEWxRRGXxpJ045+
 zUUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=2qKG002AHQ5ixqmdlB2lr0Q9l9uQbSQWgSEXoxGPsYg=;
 b=XtxQ8d2UvQTnLCeq9o1d8ODqE4E5QtcyIObI47zOOrjUAi7chaEGkcFMkp6Bg31uuR
 PahpmxXQZ4ZulHbsCAylCFd3z2OJLYcfk4gCICOtZ/DInQlrEZcZPHAmCdUMZQbb2guQ
 xEduyDXLUPSKgrQHgwwSTh3Up5Y+2LURqi3BgSNcbK2pbR+bjtiy4lBpbwewJLQoaE2e
 UDcqWxMXPTF5qCCuxXfgMcihttOMS47dpnUCJ+egBbTSSb5Y31pmkJZBxBKEz6/AmY/b
 sTXJW0bDwovZiSZ5/3vRE+4cOJcsOfnE8+I/zU4XIVDcnDVFobxrAsJ65F0OGrGgOcP2
 K3uA==
X-Gm-Message-State: AOAM5313CG/jCM2PtnfTQwz8AfxunPkJtuhTnGzqbqGWGYKgKA1gjFI3
 BCpnWaA4Lw+qO6uj0IlYIEdLBA==
X-Google-Smtp-Source: ABdhPJwLBA/yYJuKjgqd5wi7A9onw6dpukiyzdaPtfggBe56WopRUcBCxD+PEUClh2XCu5oqbqDcsA==
X-Received: by 2002:a63:b74f:: with SMTP id w15mr6269306pgt.314.1594937077559; 
 Thu, 16 Jul 2020 15:04:37 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id p1sm977005pja.2.2020.07.16.15.04.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 16 Jul 2020 15:04:37 -0700 (PDT)
Date: Thu, 16 Jul 2020 15:04:29 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Message-ID: <20200716150429.664a524e@hermes.lan>
In-Reply-To: <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com>
References: <20200604210200.25405-1-stephen@networkplumber.org>
 <20200701202359.17006-1-stephen@networkplumber.org>
 <20200701202359.17006-26-stephen@networkplumber.org>
 <e93c14df-665b-e567-51f2-62c5808c3bb7@intel.com>
 <20200715132910.5aaa11ed@hermes.lan>
 <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 16 Jul 2020 14:41:41 +0100
"Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:

> On 15-Jul-20 9:29 PM, Stephen Hemminger wrote:
> > On Wed, 15 Jul 2020 14:28:17 +0100
> > "Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:
> >   
> >>> -#define SKIP_MASTER	SKIP_INITIAL
> >>> -#define CALL_MASTER	CALL_INITIAL
> >>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL
> >>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL  
> >>
> >> Presumably this is a generic header, should we introduce GCC-specific
> >> things there?  
> > 
> > It works with Clang as well. Likely ICC but don't have that.
> >   
> 
> What about MSVC?
> 

_Pragma is C99 standard so MSVC know it.
MSVC should ignore any pragman it doesn't understand.

There is a better pragma for deprecating keywords in MSVC, but GCC and Clang don't
understand it.