From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 359DDA0527; Fri, 17 Jul 2020 00:05:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D9122C58; Fri, 17 Jul 2020 00:05:39 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 9576C2C57 for ; Fri, 17 Jul 2020 00:05:38 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id x72so4337635pfc.6 for ; Thu, 16 Jul 2020 15:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HfNj7J2IdGW1FpLkNyBxSpfpBApPyfDH9b3+eD0qHVY=; b=xx7FfbsRxIgtkRnfYMYKWIFRO4xuvlI2aROd/QlXkfR2YBuoI+VJ3AMQ1IiyAdeQfQ mUYaYwc3Ael/53f7HHblOrmp25EXblb3V6pGjyB2UTYg1BoXJp+jMQLz6a1vXYJNV10B C2oYtGEiDvRk/dzPQIdG36TANBv8Vq8ljGTHzGehrwHNimfMQH8rDyQjOC02AcauJG7I T/emKg5bXo8L+aBnJ4FAmalXFyvLn8q5o0IztlvJYtFGcARB6pTFUvSovNB7LtPmxLlp KuPJ4hyp12sVf8fyJalslBIQ8dT/smqFUwdDun1EkoDNGtrbTFI/hPF1bFjddDFu6QZM ftCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HfNj7J2IdGW1FpLkNyBxSpfpBApPyfDH9b3+eD0qHVY=; b=iQoGZv8nfC44y+w2vbyZsTLkc6y6KW5sheUW0aUrBGZiu0WYmcNqQyGNtMKrO/h9Jq 64/tyz2rJiGNgNzR3RnY3NcOQtQ5uVnLBcXTRhLpied2znmWSaIF7mJL2wLnG+MEeTrW 3qOEfajXzGbb5Sb7ciw4xHu7SJ8B1F3czO3YoFqeheglvGA2R+B90Kb5vqS2ANT1A3Oo HuBurdCUw/jmR3bzxTgohrVt1klFug0VadqBeL3TPMTUpG6pflyyuXHgyObz6ejip40x eeKTlwShbdeJZ8Hsfnbjz2Wo8NiZ9sQFIQBgmSKf4jcJBpkNiAiKDGVlUEisaWfG6zWS vCFQ== X-Gm-Message-State: AOAM531txTlhHeQ64F7b+148D8YFg8OFTQxPv2t53D6N556WRBxhGchz 3LleEqXCngh7BP2N4VlPF/6Jr2oIGjMDyg== X-Google-Smtp-Source: ABdhPJysOC46s5PybccK3kKxTuOMigBhV8UDWt77FXys0+9lP5z7bTSC4yGRkTqLur18PHdALN5hHA== X-Received: by 2002:aa7:9abc:: with SMTP id x28mr5492616pfi.145.1594937137823; Thu, 16 Jul 2020 15:05:37 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i125sm5800418pgd.21.2020.07.16.15.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 15:05:37 -0700 (PDT) Date: Thu, 16 Jul 2020 15:05:35 -0700 From: Stephen Hemminger To: "Burakov, Anatoly" Cc: dev@dpdk.org Message-ID: <20200716150535.6af974eb@hermes.lan> In-Reply-To: <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-26-stephen@networkplumber.org> <20200715132910.5aaa11ed@hermes.lan> <2e34fe08-6548-e474-a7bc-f10e4bef947a@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: > On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > > On Wed, 15 Jul 2020 14:28:17 +0100 > > "Burakov, Anatoly" wrote: > > > >>> -#define SKIP_MASTER SKIP_INITIAL > >>> -#define CALL_MASTER CALL_INITIAL > >>> +#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL > >>> +#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL > >> > >> Presumably this is a generic header, should we introduce GCC-specific > >> things there? > > > > It works with Clang as well. Likely ICC but don't have that. > > > > What about MSVC? > The compiler issues a warning when it finds a pragma that it doesn't recognize, and continues compilation.