From: Akhil Goyal <akhil.goyal@nxp.com>
To: dev@dpdk.org
Cc: declan.doherty@intel.com, asomalap@amd.com, anoobj@marvell.com,
roy.fan.zhang@intel.com, fiona.trahe@intel.com,
rnagadheeraj@marvell.com, adwivedi@marvell.com,
jianjay.zhou@huawei.com, pablo.de.lara.guarch@intel.com,
adamx.dybkowski@intel.com, Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases
Date: Fri, 17 Jul 2020 00:37:13 +0530 [thread overview]
Message-ID: <20200716190713.23296-1-akhil.goyal@nxp.com> (raw)
In-Reply-To: <20200520152612.2920-1-akhil.goyal@nxp.com>
blockcipher cases are either returning TEST_SUCCESS
or TEST_FAILED as status, but the test may not be
supported by the PMD which is also a success case
for the PMD. Hence checking for status == TEST_FAILED
for setting the overall status as failed.
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
app/test/test_cryptodev_blockcipher.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index 642b54971..221262341 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -107,7 +107,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
"Test Skipped.\n");
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN,
"SKIPPED");
- return 0;
+ return TEST_SKIPPED;
}
}
if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_SG) {
@@ -120,7 +120,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
"Test Skipped.\n");
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN,
"SKIPPED");
- return 0;
+ return TEST_SKIPPED;
}
} else {
if (!(feat_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) {
@@ -129,7 +129,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
"Test Skipped.\n");
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN,
"SKIPPED");
- return 0;
+ return TEST_SKIPPED;
}
}
@@ -146,7 +146,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
"Test Skipped.\n");
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN,
"SKIPPED");
- return 0;
+ return TEST_SKIPPED;
}
}
@@ -163,7 +163,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
"Device does not support this algorithm."
"Test Skipped.\n");
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED");
- return 0;
+ return TEST_SKIPPED;
}
/* preparing data */
@@ -435,6 +435,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
init_xform, sess_priv_mpool);
if (status == -ENOTSUP) {
snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "UNSUPPORTED");
+ status = TEST_SKIPPED;
goto error_exit;
}
if (!sess || status < 0) {
@@ -780,9 +781,8 @@ test_blockcipher_all_tests(struct rte_mempool *mbuf_pool,
printf(" %u) TestCase %s %s\n", test_index ++,
tc->test_descr, test_msg);
- if (status != TEST_SUCCESS) {
- if (overall_status == TEST_SUCCESS)
- overall_status = status;
+ if (status == TEST_FAILED) {
+ overall_status = status;
if (tc->feature_mask & BLOCKCIPHER_TEST_FEATURE_STOPPER)
break;
--
2.17.1
next prev parent reply other threads:[~2020-07-16 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:26 [dpdk-dev] [PATCH] " akhil.goyal
2020-05-21 7:52 ` Ruifeng Wang
2020-07-16 19:07 ` Akhil Goyal [this message]
2020-07-20 9:27 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2020-07-20 9:42 ` Bruce Richardson
2020-07-20 10:18 ` Ankur Dwivedi
2020-07-20 10:20 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716190713.23296-1-akhil.goyal@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=adamx.dybkowski@intel.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).