From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4F59A0527; Sat, 18 Jul 2020 04:24:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 888CD1BEE7; Sat, 18 Jul 2020 04:24:04 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id A6D272C2B for ; Sat, 18 Jul 2020 04:24:03 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id a9so1674173pjd.3 for ; Fri, 17 Jul 2020 19:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aAxq8H5Tlwlb0jd6xguOFPTGlKNrhsle0brEzuMFi60=; b=OQIph8fJeeD+iBRv7qA9BAZX6ODFzw3YaH9RwK/lSuIYKEM0rtyrpbwZhaWxyg+mP2 KDq0n8Wxzg6TkUubnaFBd7YTveBg1uUQSeCqn9eOz3BzDQByxb/GWLugGshbmhLTYWuG emGifUtxrUuWOPPYx0bYJsARAO4P2Ja+DbhOKBCRDx7+cqNXK6w2L+ASbmzc3S/TU4f4 RJ2/JqZ+ILcrxg6ghAaqG9xDmgWQmuSh26P6zj2BVtdA/kRnD6c4ynn1oRnR2HQoGI7p 9nonJ5c2ax1bWCoBBb8QtSxje8b70EZYr90Oipb2NIzU73D8C5n2BsFXOVghI4j/a9cl edpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aAxq8H5Tlwlb0jd6xguOFPTGlKNrhsle0brEzuMFi60=; b=OZzkUIu9PgCr+H0MSzuLXJYdnh5Ps7kRuTwZbBkOkGcdoMZEN7G/d0LPOxxx+3T6Td 7AUIISlY6MStFYEQFIcWGIzk6LYSms8BtkSWrBq+qRziwMPbkuKcXPmWKvJnnfCdK2qT LIXMbI+51VbpJGCiS9Xct5zlzSc0+ZZXUmKpMfCkomTeUlAmXiOSzqNCnxQWcy2TUzfb ntyaUaaFvjL0B+WoIx0vk3LdDHoJ5wSFwKoLYygLhrpoGAjjl8hX5r0gJirbfgi7Q09n IA7csqrCPPAbwzBHH3QciHtNFyuaWgORPBVJUsvIMRyttTR3WLaTwVzMzmzRJslFj2NM yUMQ== X-Gm-Message-State: AOAM530jMVIRPPVgeUQkLxAwf9TH27s0WJEHd2JdD5T7j8FIndJXV+Ev jDSm/nrO6BTYHGkEFfct3U1PeA== X-Google-Smtp-Source: ABdhPJwVt4ZOPqKI0fj1DcbdD6tGQm6RadH19cWSeI8St2Z0jMYcQv/2NFHH4Fo2oDSFpR3GvMZ+tg== X-Received: by 2002:a17:902:ea8a:: with SMTP id x10mr9672485plb.95.1595039042865; Fri, 17 Jul 2020 19:24:02 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q24sm8513546pgg.3.2020.07.17.19.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 19:24:02 -0700 (PDT) Date: Fri, 17 Jul 2020 19:23:54 -0700 From: Stephen Hemminger To: "Burakov, Anatoly" Cc: dev@dpdk.org Message-ID: <20200717192354.4d53bbce@hermes.lan> In-Reply-To: <78724d56-76d3-f0df-c80c-dab41299d1ba@intel.com> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200701202359.17006-1-stephen@networkplumber.org> <20200701202359.17006-27-stephen@networkplumber.org> <78724d56-76d3-f0df-c80c-dab41299d1ba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 26/27] memif: replace master/slave with server/client X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 17 Jul 2020 14:01:46 +0100 "Burakov, Anatoly" wrote: > On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: > > The names master and slave have no place inside this driver. > > It is really a traditional client server model, so use those names. > > > > Signed-off-by: Stephen Hemminger > > --- > > Isn't this an externally visible change? Or do we not provide any > guarantees for PMD devargs working across releases? > > In any case, i think a release notes mention of this would be nice to have. > > Otherwise, i took a quick look, LGTM > > Acked-by: Anatoly Burakov > It does change devargs. Let me go back and put in release note, and add compatibility (nag) layer.