From: patrick.fu@intel.com
To: dev@dpdk.org, maxime.coquelin@redhat.com, chenbo.xia@intel.com
Cc: patrick.fu@intel.com
Subject: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path
Date: Mon, 20 Jul 2020 10:52:42 +0800 [thread overview]
Message-ID: <20200720025242.3066787-1-patrick.fu@intel.com> (raw)
From: Patrick Fu <patrick.fu@intel.com>
Async copy fails when ring buffer cross two physical pages. This patch
fix the failure by letting copies occur in sync mode if crossing page
buffers are given.
Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring")
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
lib/librte_vhost/virtio_net.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 1d0be3dd4..44b22a8ad 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -1071,16 +1071,10 @@ async_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
}
cpy_len = RTE_MIN(buf_avail, mbuf_avail);
+ hpa = (void *)(uintptr_t)gpa_to_hpa(dev,
+ buf_iova + buf_offset, cpy_len);
- if (unlikely(cpy_len >= cpy_threshold)) {
- hpa = (void *)(uintptr_t)gpa_to_hpa(dev,
- buf_iova + buf_offset, cpy_len);
-
- if (unlikely(!hpa)) {
- error = -1;
- goto out;
- }
-
+ if (unlikely(cpy_len >= cpy_threshold && hpa)) {
async_fill_vec(src_iovec + tvec_idx,
(void *)(uintptr_t)rte_pktmbuf_iova_offset(m,
mbuf_offset), cpy_len);
--
2.18.4
next reply other threads:[~2020-07-20 2:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 2:52 patrick.fu [this message]
2020-07-20 16:39 ` Maxime Coquelin
2020-07-21 2:57 ` Fu, Patrick
2020-07-21 8:35 ` Maxime Coquelin
2020-07-21 9:01 ` Fu, Patrick
2020-07-24 13:49 ` [dpdk-dev] [PATCH v2] vhost: fix async copy fail on multi-page buffers patrick.fu
2020-07-27 6:33 ` [dpdk-dev] [PATCH v3] " patrick.fu
2020-07-27 13:14 ` Xia, Chenbo
2020-07-28 3:09 ` Fu, Patrick
2020-07-28 3:28 ` [dpdk-dev] [PATCH v4] " patrick.fu
2020-07-28 13:55 ` Maxime Coquelin
2020-07-29 1:40 ` Fu, Patrick
2020-07-29 2:05 ` Fu, Patrick
2020-07-29 2:04 ` [dpdk-dev] [PATCH v5] " Patrick Fu
2020-07-29 14:24 ` Maxime Coquelin
2020-07-29 14:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720025242.3066787-1-patrick.fu@intel.com \
--to=patrick.fu@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).