From: Jeff Guo <jia.guo@intel.com>
To: qi.z.zhang@intel.com, qiming.yang@intel.com
Cc: dev@dpdk.org, simei.su@intel.com, jia.guo@intel.com
Subject: [dpdk-dev] [dpdk-dev v1] net/ice: fix symmetric hash configuration
Date: Mon, 20 Jul 2020 17:13:56 +0800 [thread overview]
Message-ID: <20200720091356.59144-1-jia.guo@intel.com> (raw)
Some protocol don't support symmetric hash, need to handle these cases.
When set an invalid symmetric hash rule, just return failed.
Fixes: 7d0824387e63 ("net/ice: fix invalid RSS type")
Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
drivers/net/ice/ice_hash.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 13f88d37c..e535e4b95 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1026,6 +1026,7 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
const struct rte_flow_action *action;
uint64_t rss_attr_src_dst;
uint64_t rss_attr_l3_pre;
+ uint64_t rss_attr_symm;
uint64_t rss_attr_all;
uint64_t rss_type;
uint16_t i;
@@ -1089,6 +1090,15 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
RTE_ETH_RSS_L3_PRE48 |
RTE_ETH_RSS_L3_PRE64;
+ rss_attr_symm = ETH_RSS_IPV4 |
+ ETH_RSS_NONFRAG_IPV4_UDP |
+ ETH_RSS_NONFRAG_IPV4_TCP |
+ ETH_RSS_NONFRAG_IPV4_SCTP |
+ ETH_RSS_IPV6 |
+ ETH_RSS_NONFRAG_IPV6_UDP |
+ ETH_RSS_NONFRAG_IPV6_TCP |
+ ETH_RSS_NONFRAG_IPV6_SCTP;
+
rss_attr_all = rss_attr_src_dst | rss_attr_l3_pre;
/* Check if only SRC/DST_ONLY or ipv6 prefix exists. */
@@ -1103,7 +1113,8 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
*/
if (rss->func ==
RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
- if (rss_type & rss_attr_src_dst)
+ if (rss_type & (rss_attr_src_dst |
+ ~rss_attr_symm))
return rte_flow_error_set(error,
ENOTSUP,
RTE_FLOW_ERROR_TYPE_ACTION,
--
2.20.1
next reply other threads:[~2020-07-20 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:13 Jeff Guo [this message]
2020-07-21 5:10 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720091356.59144-1-jia.guo@intel.com \
--to=jia.guo@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).