From: Bruce Richardson <bruce.richardson@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: "asomalap@amd.com" <asomalap@amd.com>,
"anoobj@marvell.com" <anoobj@marvell.com>,
"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"rnagadheeraj@marvell.com" <rnagadheeraj@marvell.com>,
"adwivedi@marvell.com" <adwivedi@marvell.com>,
"jianjay.zhou@huawei.com" <jianjay.zhou@huawei.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"adamx.dybkowski@intel.com" <adamx.dybkowski@intel.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases
Date: Mon, 20 Jul 2020 10:42:52 +0100 [thread overview]
Message-ID: <20200720094252.GA726@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <VI1PR04MB31682D824E4D0BB83BBE4AB4E67B0@VI1PR04MB3168.eurprd04.prod.outlook.com>
On Mon, Jul 20, 2020 at 09:27:57AM +0000, Akhil Goyal wrote:
> Hi All,
>
> > blockcipher cases are either returning TEST_SUCCESS
> > or TEST_FAILED as status, but the test may not be
> > supported by the PMD which is also a success case
> > for the PMD. Hence checking for status == TEST_FAILED
> > for setting the overall status as failed.
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
>
> Any comments on this patch?
>
Not an expert on the crypto area, but on code-review the changes look good
to me as it makes the return value match the output describing what is
happening.
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-07-20 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:26 [dpdk-dev] [PATCH] " akhil.goyal
2020-05-21 7:52 ` Ruifeng Wang
2020-07-16 19:07 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2020-07-20 9:27 ` Akhil Goyal
2020-07-20 9:42 ` Bruce Richardson [this message]
2020-07-20 10:18 ` Ankur Dwivedi
2020-07-20 10:20 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720094252.GA726@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adamx.dybkowski@intel.com \
--cc=adwivedi@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=asomalap@amd.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=rnagadheeraj@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).