From: zhihongx.peng@intel.com
To: wei.zhao1@intel.com, jia.guo@intel.com
Cc: dev@dpdk.org, Peng Zhihong <zhihongx.peng@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability
Date: Mon, 20 Jul 2020 23:05:14 -0400 [thread overview]
Message-ID: <20200721030514.18947-1-zhihongx.peng@intel.com> (raw)
In-Reply-To: <20200720064849.14795-1-zhihongx.peng@intel.com>
From: Peng Zhihong <zhihongx.peng@intel.com>
The rte_eth_dev_set_vlan_offload function will check vlan rx offload
capability, the i350/i210/i211 nics have vlan extend feature but
DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will
cause setting fail. So need to add this capability in
igb_get_rx_port_offloads_capa function.
Fixes: ef990fb56e55 ("net/e1000: convert to new Rx offloads API")
Cc: stable@dpdk.org
Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
drivers/net/e1000/igb_rxtx.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 5717cdb70..6411924e0 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -1637,8 +1637,10 @@ uint64_t
igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
{
uint64_t rx_offload_capa;
+ struct e1000_hw *hw;
+
+ hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
- RTE_SET_USED(dev);
rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
DEV_RX_OFFLOAD_VLAN_FILTER |
DEV_RX_OFFLOAD_IPV4_CKSUM |
@@ -1649,6 +1651,11 @@ igb_get_rx_port_offloads_capa(struct rte_eth_dev *dev)
DEV_RX_OFFLOAD_SCATTER |
DEV_RX_OFFLOAD_RSS_HASH;
+ if (hw->mac.type == e1000_i350 ||
+ hw->mac.type == e1000_i210 ||
+ hw->mac.type == e1000_i211)
+ rx_offload_capa |= DEV_RX_OFFLOAD_VLAN_EXTEND;
+
return rx_offload_capa;
}
--
2.17.1
next prev parent reply other threads:[~2020-07-21 3:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 1:46 [dpdk-dev] [DPDK] net/e1000: add the VLAN capabilities of NIC zhihongx.peng
2020-07-20 1:59 ` Zhao1, Wei
2020-07-20 6:48 ` [dpdk-dev] [DPDK v2] " zhihongx.peng
2020-07-21 3:05 ` zhihongx.peng [this message]
2020-07-21 3:31 ` [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability Zhao1, Wei
2020-07-21 5:05 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721030514.18947-1-zhihongx.peng@intel.com \
--to=zhihongx.peng@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).