From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36A06A0526; Wed, 22 Jul 2020 14:59:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A15B91BFD4; Wed, 22 Jul 2020 14:59:56 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A684E1BFD1 for ; Wed, 22 Jul 2020 14:59:55 +0200 (CEST) IronPort-SDR: sOCegQ8+B2nsFLSOPnqKYvVghm7Ra7Bf9Vut/MX7iCEIh2Fpb4b+B8IlHFVy3+Le+yrL+bhMkf nC3WaQoc/09w== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="147817675" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="147817675" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 05:59:53 -0700 IronPort-SDR: Jg0dXpOQKyrUSFgTU/xuscPlcw4XouUaZFDtYUtC6wsYATK0ROA0dZRYKftxiVg65gnUnVOh94 UFSDy90zn+VA== X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="462445466" Received: from jmcman1x-mobl2.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.213.194.32]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Jul 2020 05:59:52 -0700 Date: Wed, 22 Jul 2020 13:59:49 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: John McNamara , Marko Kovacevic , dev@dpdk.org Message-ID: <20200722125949.GA1031@bricha3-MOBL.ger.corp.intel.com> References: <20200721153950.748927-1-bruce.richardson@intel.com> <1786897.AIzr81cTuv@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1786897.AIzr81cTuv@thomas> Subject: Re: [dpdk-dev] [PATCH] doc/guides: remove dependency on make build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 22, 2020 at 02:45:54PM +0200, Thomas Monjalon wrote: > 21/07/2020 17:39, Bruce Richardson: > > When building the DPDK guide documents, the DPDK version information was > > pulled using "make showversion", which meant there was a dependency on > > the DPDK make-based build system. Change this to just read the data from > > the VERSION file in the root directory. > > > > Signed-off-by: Bruce Richardson > > --- > > NOTE: When make build system is completed removed, we can change the > > relative path to the VERSION file i.e. "../../", to instead pull the > > path from "MESON_SOURCE_ROOT" in the environment, which should be more > > robust. > > Yes it would be a bit better. > If we merge this patch in 20.08, we'll forget about this improvement :) > I suggest waiting 20.11 to merge the definitive improvement. > I'd prefer now, but I can be patient, I suppose. :-)