From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BCFA6A0527;
	Thu, 23 Jul 2020 09:09:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C45C31C002;
	Thu, 23 Jul 2020 09:08:49 +0200 (CEST)
Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])
 by dpdk.org (Postfix) with ESMTP id BF6451BF94
 for <dev@dpdk.org>; Thu, 23 Jul 2020 09:08:43 +0200 (CEST)
Received: from Internal Mail-Server by MTLPINE1 (envelope-from
 fady@mellanox.com) with SMTP; 23 Jul 2020 10:08:41 +0300
Received: from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx
 [10.237.1.5])
 by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06N78eGj027335;
 Thu, 23 Jul 2020 10:08:41 +0300
From: Fady Bader <fady@mellanox.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,
 yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
 harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
 pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com
Date: Thu, 23 Jul 2020 10:08:24 +0300
Message-Id: <20200723070825.6448-3-fady@mellanox.com>
X-Mailer: git-send-email 2.16.1.windows.4
In-Reply-To: <20200723070825.6448-1-fady@mellanox.com>
References: <20200610120040.17968-1-fady@mellanox.com>
 <20200723070825.6448-1-fady@mellanox.com>
Subject: [dpdk-dev] [PATCH v4 2/3] net: replace htons with RTE_BE16
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

htons wasn't defined in Windows for the minGW compiler.
htons was replaced with RTE_BE16 in order to compile
under Windows.

Signed-off-by: Fady Bader <fady@mellanox.com>
---
 lib/librte_net/rte_arp.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/librte_net/rte_arp.c b/lib/librte_net/rte_arp.c
index 784b7f48fa..5c1e27b8c0 100644
--- a/lib/librte_net/rte_arp.c
+++ b/lib/librte_net/rte_arp.c
@@ -2,9 +2,8 @@
  * Copyright(c) 2018 Intel Corporation
  */
 
-#include <arpa/inet.h>
-
 #include <rte_arp.h>
+#include <rte_byteorder.h>
 
 #define RARP_PKT_SIZE	64
 struct rte_mbuf *
@@ -32,15 +31,15 @@ rte_net_make_rarp_packet(struct rte_mempool *mpool,
 	/* Ethernet header. */
 	memset(eth_hdr->d_addr.addr_bytes, 0xff, RTE_ETHER_ADDR_LEN);
 	rte_ether_addr_copy(mac, &eth_hdr->s_addr);
-	eth_hdr->ether_type = htons(RTE_ETHER_TYPE_RARP);
+	eth_hdr->ether_type = RTE_BE16(RTE_ETHER_TYPE_RARP);
 
 	/* RARP header. */
 	rarp = (struct rte_arp_hdr *)(eth_hdr + 1);
-	rarp->arp_hardware = htons(RTE_ARP_HRD_ETHER);
-	rarp->arp_protocol = htons(RTE_ETHER_TYPE_IPV4);
+	rarp->arp_hardware = RTE_BE16(RTE_ARP_HRD_ETHER);
+	rarp->arp_protocol = RTE_BE16(RTE_ETHER_TYPE_IPV4);
 	rarp->arp_hlen = RTE_ETHER_ADDR_LEN;
 	rarp->arp_plen = 4;
-	rarp->arp_opcode  = htons(RTE_ARP_OP_REVREQUEST);
+	rarp->arp_opcode  = RTE_BE16(RTE_ARP_OP_REVREQUEST);
 
 	rte_ether_addr_copy(mac, &rarp->arp_data.arp_sha);
 	rte_ether_addr_copy(mac, &rarp->arp_data.arp_tha);
-- 
2.16.1.windows.4