From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A8573A0526;
	Fri, 24 Jul 2020 16:25:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3535D1C0AF;
	Fri, 24 Jul 2020 16:24:37 +0200 (CEST)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20071.outbound.protection.outlook.com [40.107.2.71])
 by dpdk.org (Postfix) with ESMTP id 43D981C042
 for <dev@dpdk.org>; Fri, 24 Jul 2020 16:24:33 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aSlGYqH9bUNsxN+iPply3vbuF/qsjwmDPpYRpbMWTkkQropGpBdtRXV8o5icQd6DGghn+mUJVZ+WQiAEwxilG5q6NB+gi2cNGSSzSmFy3YZhk2QBbZMCfVX/8f4z17baZ9nu2H1eJ5xfk6UrIqoSROg8p4EBuvDdafdY4M8m3TzpiVaC8ux3K/9RPmTc/nROgUAMhDmUh2NqPvRP7okmdqYw08UpGoSQCh5gx/Oco38lJmiYaFWll2CzTpxbgAh3wuZ6LcQRbKz3X/9G3IFMD08XJJIrXzDIu9p/CKMjuvUeKq9vlKizpWOB+u6XhyP1KIUG8H7W9q4m9FTHnQ1mfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=;
 b=jlx6vbb88FuhrrbNg1H9YOZhZjKo0laSZSQq6yZ9cRlzQyQIniUqDgb/6SHzGE8eE8nDT8UVtRjU4YsQjibL675G8NTzRQKU+b8Y6l44FxrXHWUAtpHFv1IZjdhWJD3bz6ZQ8sebp7iTC10f1wXnu9zqWpaXhH45YiNNWsW97mBEWF6W3fE24a+vfFhbD/HIIeeHJJegCvXBvlL9iE7Kyi7c96GRKRhVvpt+HeRuXfLKltnWMJ57KkzdHX5KcSXvJX2ZIPNLbkQ/gAB5gEnYZgdsDSY5YtE8m0WXNphf7z40K09LJ5k7qCE/G2VXbHxYzn9hTXGCuCO3DT99yNiMeQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;
 dkim=pass header.d=mellanox.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=;
 b=n3csllXcUm3XAOXrI8E70dZ9lfPUxbGxSimTowX0jLPU0k8VujjWu/IzcrzZaDZb+b9fPsTtIeTsWg3eY4FQH6fV7OYRBZRExtPx35p3gm9uEhUzn8Wf4TxlLtPRW6t66po+ZWJQWqyaJvyZI3e2iOb09mEPwc/V4aT8s17ZBOM=
Authentication-Results: dpdk.org; dkim=none (message not signed)
 header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;
Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32)
 by AM4PR05MB3203.eurprd05.prod.outlook.com (2603:10a6:205:6::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Fri, 24 Jul
 2020 14:24:31 +0000
Received: from AM0PR05MB4866.eurprd05.prod.outlook.com
 ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com
 ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020
 14:24:31 +0000
From: Parav Pandit <parav@mellanox.com>
To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net
Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,
 joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>
Date: Fri, 24 Jul 2020 17:23:57 +0300
Message-Id: <20200724142403.6132-5-parav@mellanox.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20200724142403.6132-1-parav@mellanox.com>
References: <20200610171728.89-2-parav@mellanox.com>
 <20200724142403.6132-1-parav@mellanox.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: DM6PR02CA0136.namprd02.prod.outlook.com
 (2603:10b6:5:1b4::38) To AM0PR05MB4866.eurprd05.prod.outlook.com
 (2603:10a6:208:c0::32)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by
 DM6PR02CA0136.namprd02.prod.outlook.com (2603:10b6:5:1b4::38) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3216.21 via Frontend Transport; Fri, 24 Jul 2020 14:24:30 +0000
X-Mailer: git-send-email 2.26.2
X-Originating-IP: [208.176.44.194]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 282ebbed-785a-41cd-1db7-08d82fdd4815
X-MS-TrafficTypeDiagnostic: AM4PR05MB3203:
X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM4PR05MB32037F66C615F35079542BD5D1770@AM4PR05MB3203.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:327;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nrceaUCTmRJnlI/FR67sehvO+aUJP+zyEHCRXgRC+4BRfplWbaoq0aSBSs/Qx/3HkI+TFLJWUh++G3xS35bEpxrU1E6DYoUPmkqBnO6ixrZc7cLEAKgTu4toCR4dxh4PQnZOjwSm226v8u/XvZT/PvsbhhIn1qn13YYGyWk2k9EZQ222gDkGITz7iRznmIbpboWX0sd6D2wgV8Haib1vjJ9+c+hBwFnwEqnAMKqmhcP4NLysBSjsI0gUc712FD+5sc+uwyRmyHzklJ4HbRNN+nNGcPGR9pT1Nk3YWxXckqLWfN95rHQK/iLsony47GFN
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE;
 SFTY:;
 SFS:(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(5660300002)(86362001)(2616005)(956004)(6512007)(2906002)(66946007)(66476007)(66556008)(316002)(6506007)(4326008)(16526019)(186003)(26005)(107886003)(8936002)(478600001)(8676002)(6666004)(52116002)(6486002)(83380400001)(1076003)(36756003);
 DIR:OUT; SFP:1101; 
X-MS-Exchange-AntiSpam-MessageData: fWo7VfD7LDQfUZELphLDmYMsIa//BnB3aHigCK9oagwsZ2yUdwUF6xU5fl+XpL45jjvQbCqu+qwT+/qF84/JTdBJbbmY7EQLlz2JBhv+O8cJVldi60+KQ+wHtIaTNVVboLGeiYn9SegrLmWJIm1Az57Hauf12J6wyDDGRjNqeXBqumlz6EVXiHc7sB23OoKk7sFJAfhUY/JK8tB/YD5/mBJf3f1agC3my3CSkT6jmyJiJDmRe55Gw95/hh27V7xeZ79aOPznzxTjIC78Xp4xbhW15uYDNd4Uestk5uCF5Ev2Fe6dZTY/wpqHoXLEvNsVHT2NZjJZV0seVtcEb4dnAaZ7uHd1YsHSDRYhUkAu69jfw+VoKcy+uYr9qe5wOAhfunwjfba2oUxacI/noWNS0kTT7A7/rOxhEB506wKVDlJ2ECUAMcLKiS71PphWZbNPBHkmdu8BCXieRtKAI0xBdJu8R8Kyf2lkEgMU3hn0rKLIr8Gao9lgoOxkQXibzRmX
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 282ebbed-785a-41cd-1db7-08d82fdd4815
X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2020 14:24:31.7795 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: asOdcUSLMsTh/uedBVn4ngS8ZKr8UXTIq3UUXaIXhpn0Nx/ZVUmF/4RtR83wzVhnGrmX+fyRRO+//VK+sNdSsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3203
Subject: [dpdk-dev] [PATCH v9 04/10] common/mlx5: fix void parameters in
	glue wrappers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Following two errors are reported when compiled with
gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5).

drivers/common/mlx5/linux/mlx5_glue.h:188:2:
error: function declaration isn't a prototype [-Werror=strict-prototypes]

drivers/common/mlx5/linux/mlx5_glue.h:188:2:
error: function declaration isn't a prototype [-Werror=strict-prototypes]

Fix them by adding void data type in empty argument list.

Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch")
Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue")

Signed-off-by: Parav Pandit <parav@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
Changelog:
v2->v3:
 - new patch
---
 drivers/common/mlx5/linux/mlx5_glue.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h
index c4f9b006a..734ace2a3 100644
--- a/drivers/common/mlx5/linux/mlx5_glue.h
+++ b/drivers/common/mlx5/linux/mlx5_glue.h
@@ -185,11 +185,11 @@ struct mlx5_glue {
 	void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl);
 	void *(*dr_create_flow_action_dest_port)(void *domain,
 						 uint32_t port);
-	void *(*dr_create_flow_action_drop)();
+	void *(*dr_create_flow_action_drop)(void);
 	void *(*dr_create_flow_action_push_vlan)
 					(struct mlx5dv_dr_domain *domain,
 					 rte_be32_t vlan_tag);
-	void *(*dr_create_flow_action_pop_vlan)();
+	void *(*dr_create_flow_action_pop_vlan)(void);
 	void *(*dr_create_flow_tbl)(void *domain, uint32_t level);
 	int (*dr_destroy_flow_tbl)(void *tbl);
 	void *(*dr_create_domain)(struct ibv_context *ctx,
-- 
2.26.2