From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 108B2A0527; Fri, 24 Jul 2020 16:40:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C66FE1C07E; Fri, 24 Jul 2020 16:39:37 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by dpdk.org (Postfix) with ESMTP id 0A47C1C065 for ; Fri, 24 Jul 2020 16:39:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPxNcMLRxSwLC03K/l1Lg1Bjhvrv+gnIEWO8LgRAloKlOQsU8qewhlvii3RKG/S2HFyxiR9qCb2tco/ovMhEh7vQJg2lLjbEn0QsfuO+6GZ9uqnNztUSbbOsJO7zwqtVqOBF4mgjUi8QvRP6pQAFvFMu5nUkiwh7if3AkN2C/wTbxMBqstHt+5eCfwIpLjhf4R+2L7vWLjNrUWSurOj4QAv8NLON66Ou0yU+H8qp9sckrEXad6RKqWs2Y85ceiDAnzSQj9UehogN94ZqtSJQ+LyjEdys9cj9nOZBoJXea9UrU4rczScpEi5kavQL3ukY7laMl/4NhMVxXVVr44i8mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=gPaMbsjElEtlwgQVcg8knGQTPIxETCkvsd7aQAWhWrJ5lDF0ay5WXttMRWF4VhaffjurfZBsQRols3u5Wte2agxHW/y0Pb/abymlppBznv/uR0Owmf5Z5aVLzgZwJnSVb9dDvgG9oRssnJw2Odz0Dtx4d8ltjZ/Yq2ur5oXtiRgFOFAqD9ARJ2VzlEYPpgSoenx4xU0GPaejclaDOEuDQPvfFrp+0iU9GV8BoQ0+cw+OPHRVJHkO9FHmXSxd4W6Eg5CsHzXcBmW/n5wM4mtHLKLJOeVBuCFeuA5Cuqr+n5GQ9f59lpLNvL/vy3rUH7mQvcd95kRlf1xMmVDAGqepLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=92rl6cqTJPpUdxYCsCQXrb5CCdl1HT8vxMN5Ve74+0U=; b=Y0Xqz2qOGQVlDZE9pvV1imX0IELqKMDcSD5WCXxTuUKLS5yCZJhw4J8NaJt+zWGELgDEOj1he3DoHXcwm5U7QAdr0CDo4k1M84s6MxRXEiQVIgrXJDgVPteDZELzkQ7Tb+H/qnHV4gNYazoXIpMLKiFG8jsYbBSUdah/xxaywMI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4962.eurprd05.prod.outlook.com (2603:10a6:208:c3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 24 Jul 2020 14:39:32 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::eccf:72b3:bacb:f09d%5]) with mapi id 15.20.3216.024; Fri, 24 Jul 2020 14:39:32 +0000 From: Parav Pandit To: dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net Cc: rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, Parav Pandit Date: Fri, 24 Jul 2020 17:39:00 +0300 Message-Id: <20200724143906.7453-5-parav@mellanox.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200724143906.7453-1-parav@mellanox.com> References: <20200610171728.89-2-parav@mellanox.com> <20200724143906.7453-1-parav@mellanox.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA9PR10CA0025.namprd10.prod.outlook.com (2603:10b6:806:a7::30) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by SA9PR10CA0025.namprd10.prod.outlook.com (2603:10b6:806:a7::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23 via Frontend Transport; Fri, 24 Jul 2020 14:39:30 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [208.176.44.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fb5ee3ae-ae8b-47e2-ea0f-08d82fdf60db X-MS-TrafficTypeDiagnostic: AM0PR05MB4962: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wJTteMM0UJwZ0JrVVKdK6dPydc8csWYpGnA0BY7FJPS1oIub/hAB8iPYlOm1ysdKekZkDwu7n0QPa5hYupNAvT/QtHCzHxJ1DBMYybVjArC/iF31sDp0i5T/wkT+ppKsO7q5fwvqtqmt5IThhR1Vo6h+qzPlsO38PusVWCjEogvEPWrf1JlXs4RLcR8c5UoqIZvuyFbDBiDiqWDwwOVA/0i310HHyiOzcAi9OtvG4kfyGdvBDeqARzvRzNRiiJ2xEqmCwoyHjonpaX0DtgIoCuAuxGVzaI/9TLRaPdws1ekNI+7c/33i5IPjqHkhPS3p X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4866.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(8936002)(36756003)(1076003)(4326008)(26005)(52116002)(2616005)(956004)(316002)(6506007)(478600001)(16526019)(66946007)(86362001)(6512007)(83380400001)(8676002)(66476007)(66556008)(186003)(6486002)(5660300002)(107886003)(2906002)(6666004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: O+shTQZDZMl5uETZr5q2+9TWlVAitkzAyPW3scJDxIW1x5f9Fe0H+qA/6zMfix1/heropdS85fCHOE+w+XikVH+6pyc0ARLWgwYzj+kjGvvSgO5BnNNHI3H5i3z/zdsRja2v4n63ORSY836IVVMvh7bJmOVmMTxukMp40c35TuFOy+EbVrnpIkxMYVMhodQrvjSVyifjql9TkyZ5o7DRpwJyB4/XaKjgLZYQUdYCNkwkIppW2wkmLLR94gd+TjNn5ZvUR2KFu8NnWw5l2Yk8BfQiisx3I/XuW3eAUanfr48V0ySzU/p8X06r1KcrJhKJFuEBNeWmG6V0d3p42FOnooSrH7MFzzem035nDlvEEsGolclOgN9RmaTYyxVbSx6c16CZomahKjzRFfnY6DG+Uk2YHR0E+zszt4NHNblE6pKgz0d63Z+OcYMt6SCaxF46rTMmZvX1Bg8S18CjsyRUU6A0oEUGmGafXamjIbJ7gSpHtZexuArVq1Y39MbuChZ7 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb5ee3ae-ae8b-47e2-ea0f-08d82fdf60db X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2020 14:39:32.5440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vsApdqRbfRxqax3lqdLTzY9HTFLMZ6Lim21sjjziWh45j1Nc7On48q9qLv/9FjDGdW1PIjindGrB3tBHKIEDdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4962 Subject: [dpdk-dev] [PATCH v10 04/10] common/mlx5: fix void parameters in glue wrappers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following two errors are reported when compiled with gcc (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5). drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] drivers/common/mlx5/linux/mlx5_glue.h:188:2: error: function declaration isn't a prototype [-Werror=strict-prototypes] Fix them by adding void data type in empty argument list. Fixes: 34fa7c0268e7 ("net/mlx5: add drop action to Direct Verbs E-Switch") Fixes: 400d985eb586 ("net/mlx5: add VLAN push/pop DR commands to glue") Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v2->v3: - new patch --- drivers/common/mlx5/linux/mlx5_glue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_glue.h b/drivers/common/mlx5/linux/mlx5_glue.h index c4f9b006a..734ace2a3 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.h +++ b/drivers/common/mlx5/linux/mlx5_glue.h @@ -185,11 +185,11 @@ struct mlx5_glue { void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); void *(*dr_create_flow_action_dest_port)(void *domain, uint32_t port); - void *(*dr_create_flow_action_drop)(); + void *(*dr_create_flow_action_drop)(void); void *(*dr_create_flow_action_push_vlan) (struct mlx5dv_dr_domain *domain, rte_be32_t vlan_tag); - void *(*dr_create_flow_action_pop_vlan)(); + void *(*dr_create_flow_action_pop_vlan)(void); void *(*dr_create_flow_tbl)(void *domain, uint32_t level); int (*dr_destroy_flow_tbl)(void *tbl); void *(*dr_create_domain)(struct ibv_context *ctx, -- 2.26.2